From owner-svn-src-head@freebsd.org Sun Apr 7 16:12:03 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2271715633FC; Sun, 7 Apr 2019 16:12:03 +0000 (UTC) (envelope-from oshogbo.vx@gmail.com) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 850FE95CCA; Sun, 7 Apr 2019 16:12:02 +0000 (UTC) (envelope-from oshogbo.vx@gmail.com) Received: by mail-lj1-x241.google.com with SMTP id q66so9080855ljq.7; Sun, 07 Apr 2019 09:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zKBJgPPpYeE2fRAQDfKtArFbxuSMFkoVrGfEkJcwdc0=; b=VfL0w7uChzynMtA3D/Bnq4+ixUfJfp5PEw4SRoQvIGpZp+I0DfA9/dpxfAS+Xku9T/ NTBdiD/4HfAbF3JUTtgCgtnPdANj8scoTQwRLWe0bKWPDUJabY+/6fHc0bclLxlgXDpZ h5PMYIO047f5oVdm6UlixE5qhRzhmBfDTBFf4w/kbmk/hZB6dxVYEW8U2gEybazszQSL I6fXTyJ3p/TDCNdPHKO9yodD1+IoXhxqHLiVH3EPOI+QCtY11V9IMjT4f/KZQZHkxmUk M+GRghOtdtVnyAGm5pxrXvn2Yvv5BZ/b9V83hYPXceBXm6MCEsZyIixRaJb8o0S5T/eJ 9sTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=zKBJgPPpYeE2fRAQDfKtArFbxuSMFkoVrGfEkJcwdc0=; b=I+lbAUD7O5DNJDSpOmg8dWhwmDi3NKiYdf2tEgzPTQhcD4DuEACV8ekRQM0yVSlk6H kD/j6NQFry21eo7lcrIhVdQ/NXBIXy5l1vjgIp/RVK+aJJTyqsFQGIhKH6DH0pl4ZEF7 +8aUWU1BaMgSoWjWSOhRqat773X2fn5F4qf7kkHag0WAz7Djgp2tYtiqECQRSBDudQwh e5aRQNvCyBgPbnXpVieiJu6EWinRYJeJQWvAWJvQ1vwJXJ/0wgUQGTC7+4JlswjE57Kn lr9u29wW3Aos0x6utRD2wV1H8pvZXFybfzkiF8pEoYy6hrCk8E6W8NsXdQKo7zjnSfQQ pZHQ== X-Gm-Message-State: APjAAAXmgi8wyzatqlcGPNcgn97z8ZPBxtwhvTQ0p+ATY8CadGaPG7rB lAcK/4sUqWP1qXoBSlRQ6ts4aEZvM+z+dw== X-Google-Smtp-Source: APXvYqzezo02ZEqWOpPWnzwwO4+Fi6b4EN0dTH0Q5iudLC/rKitWd36K3QMZlwwOCUTUNaxfp5UOoA== X-Received: by 2002:a2e:9010:: with SMTP id h16mr13001040ljg.16.1554653521216; Sun, 07 Apr 2019 09:12:01 -0700 (PDT) Received: from x-wing (87-206-170-77.dynamic.chello.pl. [87.206.170.77]) by smtp.gmail.com with ESMTPSA id t14sm5575298lfl.38.2019.04.07.09.11.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 07 Apr 2019 09:11:59 -0700 (PDT) Sender: Mariusz Zaborski Date: Sun, 7 Apr 2019 18:11:58 +0200 From: Mariusz Zaborski To: Cy Schubert Cc: rgrimes@freebsd.org, Shawn Webb , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r345982 - in head: include lib/libc/sys sys/cddl/compat/opensolaris/sys sys/compat/cloudabi sys/compat/freebsd32 sys/compat/linux sys/kern sys/sys sys/ufs/ffs Message-ID: <20190407161158.GA40247@x-wing> References: <201904071510.x37FA7tm050626@gndrsh.dnsmgr.net> <201904071535.x37FZ7bk073860@slippy.cwsent.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ibTvN161/egqYuK8" Content-Disposition: inline In-Reply-To: <201904071535.x37FZ7bk073860@slippy.cwsent.com> User-Agent: Mutt/1.11.2 (2019-01-07) X-Rspamd-Queue-Id: 850FE95CCA X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.968,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Apr 2019 16:12:03 -0000 --ibTvN161/egqYuK8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In the https://wiki.freebsd.org/AddingSyscalls we mentions that we need to = bump __FreeBSD_version. I confirmed that with Warner. So this was my mistake. Thanks Shawn. --=20 Mariusz Zaborski oshogbo//vx | http://oshogbo.vexillium.org FreeBSD committer | https://freebsd.org Software developer | http://wheelsystems.com If it's not broken, let's fix it till it is!!1 On Sun, Apr 07, 2019 at 08:35:07AM -0700, Cy Schubert wrote: > In message <201904071510.x37FA7tm050626@gndrsh.dnsmgr.net>, "Rodney W.=20 > Grimes" > writes: > > > On April 7, 2019 7:11:52 AM PDT, Shawn Webb wr > > ote: > > > >On Sat, Apr 06, 2019 at 09:34:26AM +0000, Mariusz Zaborski wrote: > > > >> Author: oshogbo > > > >> Date: Sat Apr 6 09:34:26 2019 > > > >> New Revision: 345982 > > > >> URL: https://svnweb.freebsd.org/changeset/base/345982 > > > >>=20 > > > >> Log: > > > >> Introduce funlinkat syscall that always us to check if we are > > > >removing > > > >> the file associated with the given file descriptor. > > > >> =20 > > > >> Reviewed by: kib, asomers > > > >> Reviewed by: cem, jilles, brooks (they reviewed previous version) > > > >> Discussed with: pjd, and many others > > > >> Differential Revision: https://reviews.freebsd.org/D14567 > > > > > > > >Hey Mariusz, > > > > > > > >Is __FreeBSD_version supposed to be bumped after adding new syscalls? > > > >I can't remember off-hand. > > > > > > > >Thanks, > > >=20 > > > I don't think so. Why force the rebuild of all ports through poudrier= e over > > something that would never affect any of them? > > > > So that you can if version >=3D foo to know it is safe to use the new s= yscal? > > Or if version < foo you must use the old way. >=20 > Granted. However we do need something to avoid gratuitous rebuilds of=20 > ports. >=20 > Personally, my poudriere script adjusts the pkg version=20 > ($JAILPATH/data/packages/${JAIL}-${PORTS}/.building/.jailversion) with=20 > that of the jail version (reported by poudriere jail -i -j $JAIL),=20 > rebuilding all ports when I (the human) determines when the machine=20 > should rebuild all ports with -c. >=20 > In that regard FreeBSD version bumps occasionally seem a little=20 > gratuitous. Using the same indicator to tell whether software should be= =20 > able to use a new feature and when ports build infrastructure should=20 > summarily delete all packages forcing a rebuild of absolutely=20 > everything is probably not the best. >=20 > Just throwing out an idea, what if poudriere considers the first N=20 > bytes of __FreeBSD_version significant? Having said that, looking at=20 > __FreeBSD_version, I don't think we have enough digits to do what I was= =20 > planning on suggesting. But, you get the idea of what I'm driving at.=20 > Maybe a new macro such as __FreeBSD_ports that is incremented every=20 > time a change that affects ports? >=20 > Anyhow, I'm not too terribly concerned as what I have (selfishly=20 > speaking) works. But we may as a group might want to consider this at=20 > some point to build some efficiency into the ports part of the equation. >=20 >=20 > --=20 > Cheers, > Cy Schubert > FreeBSD UNIX: Web: http://www.FreeBSD.org >=20 > The need of the many outweighs the greed of the few. > =20 >=20 --ibTvN161/egqYuK8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkD1x0xkJXVVY1Gwf38KEGuLGxWQFAlyqIUoACgkQ38KEGuLG xWRSaQ/+K9Xb1fcdDZ5U+5bVEfQKBJJGnMjla+sGEDqTzTN24NWqs9KETAtyqXjY c7PLJxlWCaEtWZPsFMNikBm0k6OA4WaqgNS4EIdwgS2oGW9uKRv3dv1iuFzD6Ovl qt7DQd+Bb9AX/3tFamQHc6ZgDyFwWq2GzbH0g1F9XXLEdXAbK5W/itU54RxBP795 iIOwg66KcppvHZ/UytgV90+nuK8VbQqL4pFYqPCNk7vADwqWQF02GRrqWaKimmlt CA3D2q+gDWA81mb+hxc6CrhZTJxws8i/rA7qEodUjmBqlsZulLyw19/B+hVSjy/2 tx1rvvk8eIjuM/lDOQftvmjN3jLreld4Q3zZewOCYPR4CwqzaiwIwF+t5M/TLy99 jRoZXZmzeNCpvo6bDcHs5RUU1xL8Ma6diOGbMnqHLl3hptOcODEFyaxrd/frrIZ4 WmmG4RwjkVkcmsvOlB4k6PAEH3p1OeSPnMclQb8OYdZy965CaGB2M/wbUTeOtxIZ IV1zWgd2/rwSPPJRGryXAikaNNEtkHVjNxC0Y56MPr4vbwxuO1pUbkWVQAdKzvPJ L8ITyDZUIieVrsbQSwMlNq814MNoO0eXO9oaLpbZP1ArXE+eDfSobablyDVPcNxz VCFCwalaiel9p71pTPb5kxSIDdwbfYadzIbcTtxufSSlUgsatkA= =OXw0 -----END PGP SIGNATURE----- --ibTvN161/egqYuK8--