Date: Mon, 30 Jul 2001 13:43:44 -0700 From: Jordan Hubbard <jkh@freebsd.org> To: rgoodson@p-inet.net Cc: rgrover@panasas.com, freebsd-config@freebsd.org Subject: RE: sysinstall in mfsroot.flp Message-ID: <20010730134344J.jkh@freebsd.org> In-Reply-To: <3239C74599195C4D911085B3C2AF66EE20ABA3@duroc.p-inet.com> References: <3239C74599195C4D911085B3C2AF66EE20ABA3@duroc.p-inet.com>
next in thread | previous in thread | raw e-mail | index | archive | help
The ipv6 selection dialog was added by 3rd parties and it's never,
no insult to them intended, worked quite right. Since this is actually
more indicative of *another* problem, e.g. the whole yes/no dialog thing
popping up even when the user has ask for a nonInteractive script, what
do people think of the following sysinstall patch:
Index: media.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/sysinstall/media.c,v
retrieving revision 1.115
diff -u -r1.115 media.c
--- media.c 2001/07/09 09:24:03 1.115
+++ media.c 2001/07/30 20:41:27
@@ -323,10 +323,8 @@
mediaClose();
cp = variable_get(VAR_FTP_PATH);
/* If we've been through here before ... */
- if (!variable_get(VAR_NONINTERACTIVE))
- if (networkDev && cp && msgYesNo("Re-use old FTP site selection values?"))
- cp = NULL;
-
+ if (networkDev && cp && msgYesNo("Re-use old FTP site selection values?"))
+ cp = NULL;
if (!cp) {
if (!dmenuOpenSimple(&MenuMediaFTP, FALSE))
return DITEM_FAILURE;
Index: msg.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/sysinstall/msg.c,v
retrieving revision 1.57
diff -u -r1.57 msg.c
--- msg.c 2001/07/05 09:51:09 1.57
+++ msg.c 2001/07/30 20:38:21
@@ -237,6 +237,8 @@
ioctl(0, VT_ACTIVATE, 1); /* Switch back */
msgInfo(NULL);
}
+ if (variable_get(VAR_NONINTERACTIVE))
+ return 1; /* If non-interactive, return YES all the time */
ret = dialog_yesno("User Confirmation Requested", errstr, -1, -1);
restorescr(w);
return ret;
@@ -261,6 +263,8 @@
ioctl(0, VT_ACTIVATE, 1); /* Switch back */
msgInfo(NULL);
}
+ if (variable_get(VAR_NONINTERACTIVE))
+ return 0; /* If non-interactive, return NO all the time */
ret = dialog_noyes("User Confirmation Requested", errstr, -1, -1);
restorescr(w);
return ret;
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-config" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010730134344J.jkh>