From owner-cvs-all Sun Mar 11 9:23: 3 2001 Delivered-To: cvs-all@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 29DA437B71A; Sun, 11 Mar 2001 09:22:58 -0800 (PST) (envelope-from des@ofug.org) Received: (from des@localhost) by flood.ping.uio.no (8.9.3/8.9.3) id SAA36221; Sun, 11 Mar 2001 18:22:54 +0100 (CET) (envelope-from des@ofug.org) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Jake Burkholder Cc: John Baldwin , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/include mutex.h src/sys/i386/include mutex.h src/sys/ia64/include mutex.h src/sys/kern kern_mutex.c kern_fork.c src/sys/sys proc.h References: <20010309222521.E3527BA69@cr66388-a.rchrd1.on.wave.home.com> From: Dag-Erling Smorgrav Date: 11 Mar 2001 18:22:53 +0100 In-Reply-To: Jake Burkholder's message of "Fri, 09 Mar 2001 17:25:21 -0500" Message-ID: Lines: 12 User-Agent: Gnus/5.0802 (Gnus v5.8.2) Emacs/20.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Jake Burkholder writes: > > 1.106 +5 -1 src/sys/kern/kern_fork.c This one's wrong. It sets p2->p_spinlocks to 1 unconditionally, but if the kernel was compiled with WITNESS_SKIPSPIN, p_spinlocks is not decremented when the sched_lock is released, so mtx_legal2block() always fails and the kernel panics during boot. See the panic and backtrace I posted to -CURRENT. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message