From nobody Fri Nov 28 01:30:08 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dHbMP0q2nz6HcDG for ; Fri, 28 Nov 2025 01:30:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dHbMP0DdTz3Dgn for ; Fri, 28 Nov 2025 01:30:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764293409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RgDkWW5a3h9vYWff/YHh7bElUSA0OEBXHSU+wvgGJTQ=; b=no1iWC1CxrOghCWzezXWrwZu1zex920xwShGzctPNGXqtKEIrUVjBpCJPPb1lRpQ8Q/aqq 83+nfwSWcx0PVzzBY11hAr7avS72sOWubGQ2zzpJuJvEwubx+Eu2vqexbUstZ2WbeCEDiW Kj+OckawoZd9cGt6CZTL6rUvzwBVMUHbmAe+klZsuTldpCkH+OknX9yLBl3NczjczC3Df9 9N09zq9xab2oRoP7ggMYrolRNYKfKSuyY5+Zb4heYgmBtiLtiQdaHHLKf7zbkZdh9reW2p EsP2TeIdRQwFB1x4Ay1BnMIaNVpYvVRbEaCUAElH0vWhO7cS7hJ8Xy/MUwhzjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764293409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RgDkWW5a3h9vYWff/YHh7bElUSA0OEBXHSU+wvgGJTQ=; b=ZDGjQ2DZUnhwhNqUbFLwXDdgEgfaUgYcFvDmou27bJHlVNzmUvZ6t1eD7tb3CDgUAz6irO l5/YJGI+Yz8peDQNHw+Bw7i5zBrHtbzaMeLWVYObgwllsn+y2Rwwo3yWsdctVPHvjRoIrK dX4fpwutvYhZJ2EcIPCO1eNO1uJSNga/8ZRcq4AeeN0N2S1Q/1ojxfaDVFBND5k6sLJW+e MdAB0whpy03UAxMM5/4woIo6YvCf5K+oe+Kg4ybVygImEcYpZ2BXeaNVcqjAWWGcgiaiwk QPs7zLaJKAXuCMsEV/tmwceoDQLmJnRbVxhZv6/w9XvkBLbQjdvP5TXBZMRXyQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1764293409; a=rsa-sha256; cv=none; b=wQbW3ZZ9jF5Of5/rFyylqTe5SCb4InQPxVobS3A9MAzoiQk0nWGHM2pSW47YnnzT1R2RyS J1ELfPRYTTN5vih2ajLuN+ipw4hFtMVOR9Kn5wa0H2kQsDCu0AgeMxDOco4LsPgIWLRFh6 b8cdi9Slx/sCHDXM8oQLzLgQ375TYFFOVddS657kwtXeKhq9SdjXUyG/rUxbTZWIqXS51i VUkoKVeeM4bS9ImvsF8Z1VvqVZnURVZtv2daNZ3HXAazXf6L6Rj2z3jhDKhOS4TtIZJtLf hZqmsE7ezUUxiBo2/lfshnfNuYVaI3b3TMDeqtyqqIVatx2jnTYBpK0lY5Airw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dHbMN6mMgzgxd for ; Fri, 28 Nov 2025 01:30:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2a9b3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 28 Nov 2025 01:30:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 6901376f59b8 - main - kgssapi: Remove broken MOD_UNLOAD code List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6901376f59b870ddbb0d922e3455a388333cd460 Auto-Submitted: auto-generated Date: Fri, 28 Nov 2025 01:30:08 +0000 Message-Id: <6928fb20.2a9b3.132fb674@gitrepo.freebsd.org> The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=6901376f59b870ddbb0d922e3455a388333cd460 commit 6901376f59b870ddbb0d922e3455a388333cd460 Author: Ed Maste AuthorDate: 2025-11-27 16:44:08 +0000 Commit: Ed Maste CommitDate: 2025-11-28 01:29:55 +0000 kgssapi: Remove broken MOD_UNLOAD code The module panicked at unload with "recursing but non-recursive rw". There is a comment that "Unloading of the kgssapi module is not currently supported" and the MOD_UNLOAD case falls through to returning EOPNOTSUPP anyway. Just #if 0 the code in the unload path, leaving it as a hint in case someone implements unload support later on. PR: 291249 Reviewed by: rmacklem Fixes: ad704a34bc2c ("Use syscall_helper_register(9) rather than syscall_register().") Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D53949 --- sys/kgssapi/gss_impl.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/kgssapi/gss_impl.c b/sys/kgssapi/gss_impl.c index c9cd4d880695..323b379e1619 100644 --- a/sys/kgssapi/gss_impl.c +++ b/sys/kgssapi/gss_impl.c @@ -88,6 +88,7 @@ kgss_load(void) return (0); } +#if 0 static void kgss_unload(void) { @@ -96,6 +97,7 @@ kgss_unload(void) clnt_destroy(KGSS_VNET(kgss_gssd_handle)); KGSS_CURVNET_RESTORE(); } +#endif int kgss_oid_equal(const gss_OID oid1, const gss_OID oid2) @@ -297,8 +299,10 @@ kgssapi_modevent(module_t mod, int type, void *data) error = kgss_load(); break; case MOD_UNLOAD: +#if 0 kgss_unload(); mtx_destroy(&kgss_gssd_lock); +#endif /* * Unloading of the kgssapi module is not currently supported. * If somebody wants this, we would need to keep track of