From owner-freebsd-current@FreeBSD.ORG Wed Oct 3 23:58:42 2007 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8CA2716A41A for ; Wed, 3 Oct 2007 23:58:42 +0000 (UTC) (envelope-from aryeh.friedman@gmail.com) Received: from py-out-1112.google.com (py-out-1112.google.com [64.233.166.181]) by mx1.freebsd.org (Postfix) with ESMTP id 2BB5013C447 for ; Wed, 3 Oct 2007 23:58:41 +0000 (UTC) (envelope-from aryeh.friedman@gmail.com) Received: by py-out-1112.google.com with SMTP id u77so9010744pyb for ; Wed, 03 Oct 2007 16:58:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=QlCVlt+6klq9LPA9Zpo4u0weFEyCKufsUuIsLJUS8Nw=; b=Hr2jx7rd2GA/xwlhBHBM55aBeefOYyhpx1Juy/OMWai346qszS96oSsp4HtiHv9fFfAQyAsX/5LYbOgUFLBdvJFDi7uhcv9wywGz6VRHwlwBaZZLOATA3rjk6/NJnLz6vXGTwSQMQ65/BFvZW+VW0RSiAyVXIyjeBJ/qn68QoXs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=pKvl2QxAFl0yUBb9yD/8i9NRLsLhAZrBCzFES6nuOwtLYFQ38PxAflT0kBwvAxBUXzWeUcSgy4CUOp+PAD71pxc3+VMg37KjgZS3l+NVRoVqmsEdh/R1VkqFqiiet1ckmA1Ntuq031TfsVPJCdTo9j73TJyf/BwRWdN0AH2PzOg= Received: by 10.65.107.10 with SMTP id j10mr8730327qbm.1191454433190; Wed, 03 Oct 2007 16:33:53 -0700 (PDT) Received: by 10.65.105.2 with HTTP; Wed, 3 Oct 2007 16:33:53 -0700 (PDT) Message-ID: Date: Wed, 3 Oct 2007 23:33:53 +0000 From: "Aryeh Friedman" To: "Randall Stewart" In-Reply-To: <47041CE2.60603@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20071003141412.GA1311@thunderbird.tld> <47041CE2.60603@cisco.com> Cc: current@freebsd.org, Martin Kulas Subject: Re: [SCTP][patch] socket does not wake up X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 23:58:42 -0000 On 10/3/07, Randall Stewart wrote: > Martin: > > Thanks for the patch.. note that I will submit it to > re for approval after a minor fix. > > socantrcvmore(so); > > assumes you do NOT hold a lock. This code holds > the socket lock.. which is the recv sockbuf lock.. > > So if you turn witness on your kernel and run with this > you will have a double lock.. panic. > > Note to fix this right you should have it be: > SOCK_UNLOCK(so); > + socantrcvmore(so); > > Which is what I will submit to release ops.. you may want > to change this in what you are working with so you don;t > have some other side-effect issue from the double lock.. like > leaking sockets. Does this solve the many issues with warning messages and syn/ack being received after close and such? Also I think this might also be related to the re(3) patch I mentioned in an other thread