From owner-svn-src-all@freebsd.org Tue Feb 12 15:05:18 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2589E14E9664; Tue, 12 Feb 2019 15:05:18 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: from mail-it1-f171.google.com (mail-it1-f171.google.com [209.85.166.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A9C468FFD5; Tue, 12 Feb 2019 15:05:17 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: by mail-it1-f171.google.com with SMTP id z7so7939910iti.0; Tue, 12 Feb 2019 07:05:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rLtyUK1JK0jKjQz85tTjyABeoYkuVOxtOHaOal+Y2Yg=; b=apAqB0w7Cr72s7f5s1OS9QiSU0CdH9oxflvnd9U83vKQ6Wj2QL0n+nSJVlLQOWy7T2 9TGRavnKaFF709keREVrly0B9LJDhvLdzEFPmrfG5Jna2DZN6+yuC3jZ3HHi6oGixWGa 3ORjUAmWA1moUatGvx3AhUjkgEExLTxqbAo8YgLJGxQ0sUgmuxP8cwtLbhtqmGj44dex UIPAo6snH30HDp1ZhGpsx23iK9Br/RAR27GB6efV1/f51OBDOxJEvD6dvnIRox2dbjlv 5x1WWaM+AGcfSHyV40d8qv0A5HqEYQymbWKUhvVSJNnHO8nkkYmYGrLJWacJ95aGpakr NeGA== X-Gm-Message-State: AHQUAuaGF1qtcb0z9epafcggZaKTXYxGOxf4yWUsbqPJwqGoqiSpe6oL Jcvu/aMcHyNy7OQLtmWD7A60FuxwOdvoNb2Ni4RKm3Fw X-Google-Smtp-Source: AHgI3IaiFv1/KiWYAKbxDXlgO3RHPJoBXDKUban+C+Mg21dpcmRReV0JNXDviRmjMeki9rE2qLmza9vHujOHJskPHEg= X-Received: by 2002:a24:5f4c:: with SMTP id r73mr2506602itb.25.1549983910235; Tue, 12 Feb 2019 07:05:10 -0800 (PST) MIME-Version: 1.0 References: <201902120931.x1C9VIfr075163@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201902120931.x1C9VIfr075163@pdx.rh.CN85.dnsmgr.net> From: Patrick Kelsey Date: Tue, 12 Feb 2019 10:04:56 -0500 Message-ID: Subject: Re: svn commit: r344027 - in stable/12/sys: dev/vmware/vmxnet3 modules/vmware/vmxnet3 net To: rgrimes@freebsd.org Cc: John Baldwin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org X-Rspamd-Queue-Id: A9C468FFD5 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.91 / 15.00]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.92)[-0.917,0]; NEURAL_HAM_MEDIUM(-0.99)[-0.994,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 15:05:18 -0000 On Tue, Feb 12, 2019 at 4:31 AM Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > On Mon, Feb 11, 2019 at 8:13 PM Patrick Kelsey > wrote: > > > > > > > > > > > On Mon, Feb 11, 2019 at 8:08 PM John Baldwin wrote: > > > > > >> On 2/11/19 4:26 PM, Rodney W. Grimes wrote: > > >> >> Author: pkelsey > > >> >> Date: Mon Feb 11 23:24:39 2019 > > >> >> New Revision: 344027 > > >> >> URL: https://svnweb.freebsd.org/changeset/base/344027 > > >> >> > > >> >> Log: > > >> >> MFC r343291: > > >> >> Convert vmx(4) to being an iflib driver. > > >> > > > >> > I strongly object to this MFC, given the current number > > >> > of 12.0 RELEASE related iflib problems we have it is > > >> > foolish of us to iflib any more drivers in 12.0 > > >> > > >> This isn't the release branch though and presumably we have some time > > >> before > > >> 12.1 ships. If there are reports of vmx(4) breakage on stable before > 12.1 > > >> we could always revert this commit then? > > >> > > >> I've heard of some EN's for 12.0 for iflib fixes. Are those fixes in > > >> stable/12 > > >> yet or are we still waiting for them to land in HEAD and/or be merged? > > >> > > > > > > iflib.c is currently the same between head and stable/12. I've found > and > > > fixed a number of iflib bugs by developing the iflib version of the > vmx(4) > > > driver, and it's also being fielded in a product. I'm also aware that > not > > > all current driver problems are necessarily iflib problems. I think > we'd > > > be better off letting this version of vmx(4) ride it out in stable/12 > until > > > such time as we discover an actual horror that we then feel we need to > > > react to in some way other than just going ahead and fixing it. > > > > > > > > John, > > > > Which is to say, I second your motion to proceed with normal process. As > > Point of order here, per the commiters guide you do not have the option > of seconding any motion that should of never been made, per rule 6 a > request by a Maintainer to revert your change has been made. There > is no arguing on that point. > > I think you may have caused a bit of confusion when you opened with "please consider reverting this until the iflib issues are resolved", as then jhb@ and I both seem to have gone and considered it not recognizing that you were actually making a demand. -Patrick