From owner-svn-src-head@freebsd.org Thu May 17 19:28:00 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7A544EDE22F; Thu, 17 May 2018 19:28:00 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9A2BF726E3; Thu, 17 May 2018 19:27:59 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id ca4806a5; Thu, 17 May 2018 21:27:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=IMTAe6POBlu0tktOk1Ju8+oVANc=; b=lCaTFJkKRQLg5f5F/ja4WqvPsJhO YeDnWm4IDZV+x3+sqtoQ4yFeR/xN+GYSbRUrcqzNdzcSq9OvqYW7tnSGCr8UVz1j w6LRXPIl+x7WkywZaGFUMjpDLAbM27RXyWUW4xWxmSKJKZXWDdqioNRolS98ubU3 YDkVkhk5p3qYblw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=GBpNpANPFo/WkI5sD4N/4QlDFFyKoSvC78g4rKuHbAt0pXUFSf/uyr/Y +O77+lRM7KO/pqw9itpU+ZoJ57mfQlxJ4v+Ct7PK6fcVSCbhI9D4y7OyLAlP8ZzC vCLDxRmmaL5h8VX0n9zoE2d8Dzfz27LXrIVAEn2epnzt6p4Pfmw= Received: from skull.home.blih.net (ip-9.net-89-3-105.rev.numericable.fr [89.3.105.9]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 3910ed1d TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Thu, 17 May 2018 21:27:57 +0200 (CEST) Date: Thu, 17 May 2018 21:27:57 +0200 From: Emmanuel Vadot To: Pedro Giffuni Cc: Matthew Macy , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333745 - in head/sys/contrib/ck: include src Message-Id: <20180517212757.84c7b02060ca8f86e56dbee9@bidouilliste.com> In-Reply-To: <17058056-6b70-e918-dab8-63951d1bfbbd@FreeBSD.org> References: <201805171814.w4HIEA0F079835@repo.freebsd.org> <20180517203856.aa6b8b241e23b9c07483232b@bidouilliste.com> <17058056-6b70-e918-dab8-63951d1bfbbd@FreeBSD.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd12.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 19:28:00 -0000 On Thu, 17 May 2018 14:20:05 -0500 Pedro Giffuni wrote: > > On 17/05/2018 14:12, Matthew Macy wrote: > > How do I avoid problems while allowing timely updates? > > > > -M > > > > On Thu, May 17, 2018 at 11:38 AM, Emmanuel Vadot wrote: > >> Hi Matt, > >> > >> On Thu, 17 May 2018 18:14:10 +0000 (UTC) > >> Matt Macy wrote: > >> > >>> Author: mmacy > >>> Date: Thu May 17 18:14:10 2018 > >>> New Revision: 333745 > >>> URL: https://svnweb.freebsd.org/changeset/base/333745 > >>> > >>> Log: > >>> ck: add support for executing callbacks outside of main poll loop > >>> > >>> Pull in change from upstream deca119d14bfffd440770eb67cbdbeaf7b57eb7b > >>> > >>> | ck_epoch: introduce ck_epoch_deferred > >>> | > >>> | Allow for deferral to occur outside epoch poll critical loop (which may access per-CPU structures). > >>> | > >>> > >>> Approved by: sbruno > >>> > >>> Modified: > >>> head/sys/contrib/ck/include/ck_epoch.h > >>> head/sys/contrib/ck/src/ck_epoch.c > >>> > >> CK was imported in vendor-sys/ck, commiting directly into head will > >> cause some problems in the future. > > Actually ... committing to head is fine: some things just have to be fixed. This is not true, it can cause a lot of problems with futures updates if the change isn't in the vendor repo. > We do ask you try to upstream the change and re-merge things when possible. This is already upstream, Matt is just updating CK with a patch he did ( see https://github.com/concurrencykit/ck/commit/deca119d14bfffd440770eb67cbdbeaf7b57eb7b) > Pedro. -- Emmanuel Vadot