From owner-cvs-src@FreeBSD.ORG Fri Sep 16 12:48:34 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C1E7A16A41F; Fri, 16 Sep 2005 12:48:34 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 71E4043D53; Fri, 16 Sep 2005 12:48:25 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id j8GCmLfw029171; Fri, 16 Sep 2005 16:48:21 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id j8GCmLec029170; Fri, 16 Sep 2005 16:48:21 +0400 (MSD) (envelope-from yar) Date: Fri, 16 Sep 2005 16:48:21 +0400 From: Yar Tikhiy To: Gleb Smirnoff Message-ID: <20050916124820.GC23109@comp.chem.msu.su> References: <200509161144.j8GBihiM082730@repoman.freebsd.org> <20050916115312.GT53891@cell.sick.ru> <20050916123421.GB23109@comp.chem.msu.su> <20050916123710.GX53891@cell.sick.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050916123710.GX53891@cell.sick.ru> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 12:48:35 -0000 On Fri, Sep 16, 2005 at 04:37:10PM +0400, Gleb Smirnoff wrote: > On Fri, Sep 16, 2005 at 04:34:21PM +0400, Yar Tikhiy wrote: > Y> On Fri, Sep 16, 2005 at 03:53:12PM +0400, Gleb Smirnoff wrote: > Y> > On Fri, Sep 16, 2005 at 11:44:43AM +0000, Yar Tikhiy wrote: > Y> > Y> yar 2005-09-16 11:44:43 UTC > Y> > Y> > Y> > Y> FreeBSD src repository > Y> > Y> > Y> > Y> Modified files: > Y> > Y> sys/net if_vlan.c > Y> > Y> Log: > Y> > Y> Test the new M_VLANTAG packet flag before calling > Y> > Y> m_tag_locate(). This adds little overhead of a simple > Y> > Y> bitwise operation in case hardware VLAN acceleration > Y> > Y> is on, yet saves the more expensive function call if > Y> > Y> the acceleration is off. > Y> > Y> > Y> > Y> Reviewed by: ru, glebius > Y> > Y> X-MFC-after: 6.0 > Y> > ^^^^^^^^^^^^^^^^^^^ > Y> > Why? > Y> > Y> 'Cause it's more about code consistency than stability, or performance, > Y> or features. So I'd rather not bother re@ with this when they are > Y> being flooded with really important bugfixes. It shouldn't be the > Y> extra m_tag_locate() call that is likely to be a bottleneck in 6.0 ;) > > Not a bottleneck, but a significant processing addon for every > inbound packet. > > If you don't mind I will request MFC from re@ after some testing. Well, I am not happy to shift off my job upon you... But if you feel like doing it, I have no objection against MFC ;-) -- Yar