From nobody Sun Jan 7 16:58:44 2024 X-Original-To: threads@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T7Ngm0vnxz55Qrb for ; Sun, 7 Jan 2024 16:58:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T7Ngl63LVz4Ft2 for ; Sun, 7 Jan 2024 16:58:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704646723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tJEHDkx1tf8VuktEPK9jwYwOHWr94wfNP8WjSCw0EJA=; b=wvkoI4drlVXMlFX8DAyrcKCn+bd7e30PTUIOTgsUEKvnOVPa9uB1rL4yusalJrF+OOU2tl UtjHxdEywGnAfNrb8wdXg8W3apzsl0Xw6Ak0H3BhcZG2Q3mIGYJ8wIQLUrcVnwFl89Fzj/ MHqlNWLKEdDm8xV28+ckW38kmzabMTggk5xygQm7ZmtWN/HKm6GKfvhnGfC1ylJjXLQSOh 8zB/ubPgWUO2czlh6pQNRzpvtpMXCAzO/++/3W8+8KxMp09Q220+qr7XkM+D0XaWwdIG55 U/6YbFAp/8L/zY6OqGpHTWlzl3cp3HTXleNUVRKAo6Axfow1PMkg5gvLBTxUYg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704646723; a=rsa-sha256; cv=none; b=AXWGa3MdE9pT/MNPCiLaFckafE8SLiCHhgWHlMv0kecJBEC7+zRi9uipJYb119xDRzQjqh 48fNpcFVVI4s3AmSPJjt/Qe1phzaYqMzuxp18HuzujRaPeNt1lWlTfRPalXSevvx1iRyqg zJh1WAlmTsfafRUgvAS5y3jT4BpJX2gkK/F8xKtvTq7yKd78ionkqRVfLwJse5KAN5txHR eypF0jcd7tIDuRnHpK4abiRxZ2ujobe1XXP/C6bYoxSRzIxrICrWUyfsrevGTpwdmK/10q r3RJfHu9eY+RRYqTPWPYsqkMEI7h3fvdlalLQ2lN7rwfljV2IcYpis4Oa6dL/g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T7Ngl58TZzXpd for ; Sun, 7 Jan 2024 16:58:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 407GwhnW032832 for ; Sun, 7 Jan 2024 16:58:43 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 407GwhWR032831 for threads@FreeBSD.org; Sun, 7 Jan 2024 16:58:43 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: threads@FreeBSD.org Subject: [Bug 270661] taskqgroup_cpu_create does taskqueue_thread_enqueue not gtaskqueue_thread_enqueue Date: Sun, 07 Jan 2024 16:58:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: threads@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Threading List-Archive: https://lists.freebsd.org/archives/freebsd-threads List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-threads@freebsd.org X-BeenThere: freebsd-threads@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270661 --- Comment #3 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D144e7a72f476f8f8453c40532c6f95c1f= 9add7ae commit 144e7a72f476f8f8453c40532c6f95c1f9add7ae Author: Mark Johnston AuthorDate: 2023-12-31 16:36:12 +0000 Commit: Mark Johnston CommitDate: 2024-01-07 16:56:04 +0000 gtaskqueue: Fix a typo This is a no-op in practice since gtaskqueue_thread_enqueue() and taskqueue_thread_enqueue() are identical, and while _gtaskqueue_create() compares the enqueue callback pointer with gtaskqueue_thread_enqueue(), the result has no effect since TQ_FLAGS_UNLOCKED_ENQUEUE was copied directly from subr_taskqueue.c and is unused in the gtaskqueue code. Fix it anyway since it's a bug. More generally we really need to consolidate subr_taskqueue.c and subr_gtaskqueue.c. PR: 270661 MFC after: 1 week (cherry picked from commit e1f336704d308679d4178fd5063dba854b22a07b) sys/kern/subr_gtaskqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=