From owner-freebsd-gnome@FreeBSD.ORG  Sat Jun 25 00:20:33 2011
Return-Path: <owner-freebsd-gnome@FreeBSD.ORG>
Delivered-To: gnome@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 96BAB106566C;
	Sat, 25 Jun 2011 00:20:33 +0000 (UTC)
	(envelope-from marcus@freebsd.org)
Received: from av-tac-rtp.cisco.com (hen.cisco.com [64.102.19.198])
	by mx1.freebsd.org (Postfix) with ESMTP id 599FE8FC13;
	Sat, 25 Jun 2011 00:20:33 +0000 (UTC)
X-TACSUNS: Virus Scanned
Received: from rooster.cisco.com (localhost.cisco.com [127.0.0.1])
	by av-tac-rtp.cisco.com (8.13.8+Sun/8.13.8) with ESMTP id
	p5P0KWjn007196; Fri, 24 Jun 2011 20:20:32 -0400 (EDT)
Received: from fruit-rollup.marcuscom.com (jclarke-pc.cisco.com
	[172.18.254.236])
	by rooster.cisco.com (8.13.8+Sun/8.13.8) with ESMTP id p5P0KSG6029986; 
	Fri, 24 Jun 2011 20:20:28 -0400 (EDT)
Message-ID: <4E0529CC.3010406@freebsd.org>
Date: Fri, 24 Jun 2011 20:20:28 -0400
From: Joe Marcus Clarke <marcus@freebsd.org>
Organization: FreeBSD, Inc.
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
	rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11
MIME-Version: 1.0
To: Jeremy Messenger <mezz.freebsd@gmail.com>
References: <201106242028.p5OKSZJX005102@freefall.freebsd.org>	<4E04FB83.4080802@freebsd.org>
	<BANLkTinAwE__bpjUNvB1HbSq5HPbtezMzg@mail.gmail.com>
In-Reply-To: <BANLkTinAwE__bpjUNvB1HbSq5HPbtezMzg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: gnome@freebsd.org, trasz@freebsd.org, mezz@freebsd.org
Subject: Re: ports/158174: x11/gdm: fix call to setusercontext(3)
X-BeenThere: freebsd-gnome@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: GNOME for FreeBSD -- porting and maintaining
	<freebsd-gnome.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gnome>
List-Post: <mailto:freebsd-gnome@freebsd.org>
List-Help: <mailto:freebsd-gnome-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Jun 2011 00:20:33 -0000

On 6/24/11 7:13 PM, Jeremy Messenger wrote:
> On Fri, Jun 24, 2011 at 4:02 PM, Joe Marcus Clarke <marcus@freebsd.org> wrote:
>> On 6/24/11 4:28 PM, mezz@freebsd.org wrote:
>>> Synopsis: x11/gdm: fix call to setusercontext(3)
>>>
>>> State-Changed-From-To: open->feedback
>>> State-Changed-By: mezz
>>> State-Changed-When: Fri Jun 24 20:27:37 UTC 2011
>>> State-Changed-Why:
>>> It doesn't fix. It creates a bug. When I start GNOME with your patch and now
>>> I get this: http://people.freebsd.org/~mezz/gdm_pr158174.jpg
>>>
>>> Without your patch, GDM starts GNOME perfectly.
>>
>> Do you have MAC enabled in your kernel?
> 
> Yes I do... So.. I have changed from:
> 
> ---------
> LOGIN_SETALL & ~LOGIN_SETGROUP) < 0
> ---------
> 
> To:
> ---------
> LOGIN_SETALL & ~(LOGIN_SETGROUP | LOGIN_SETMAC)) < 0
> ---------
> 
> Now, the GDM starts GNOME as normal as before. Is patch with
> ~LOGIN_SETMAC good to you? Or you have different way of fix it?

I actually thought you may not have MAC in your kernel, and that is why
the init failed.  Are you seeing any syslog related to why
setusercontext() fails?  I'm guessing because there is no MAC label in
/etc/login.conf, but I'm curious to know if we can fix MAC
initialization for those that may want it.

Joe

> 
> Cheers,
> Mezz
> 
> 
>> Joe
> 
> 


-- 
Joe Marcus Clarke
FreeBSD GNOME Team	::	gnome@FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome