From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jun 3 20:30:01 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B6EE644E for ; Mon, 3 Jun 2013 20:30:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 9EA181454 for ; Mon, 3 Jun 2013 20:30:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r53KU1oe030199 for ; Mon, 3 Jun 2013 20:30:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r53KU1Jg030198; Mon, 3 Jun 2013 20:30:01 GMT (envelope-from gnats) Resent-Date: Mon, 3 Jun 2013 20:30:01 GMT Resent-Message-Id: <201306032030.r53KU1Jg030198@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mark Felder Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id E10FF3FF for ; Mon, 3 Jun 2013 20:25:28 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) by mx1.freebsd.org (Postfix) with ESMTP id B9A2B13BA for ; Mon, 3 Jun 2013 20:25:28 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r53KPMhu084934 for ; Mon, 3 Jun 2013 20:25:22 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r53KPMi1084933; Mon, 3 Jun 2013 20:25:22 GMT (envelope-from nobody) Message-Id: <201306032025.r53KPMi1084933@oldred.freebsd.org> Date: Mon, 3 Jun 2013 20:25:22 GMT From: Mark Felder To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/179271: [patch] net/vnstat add rc script X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2013 20:30:01 -0000 >Number: 179271 >Category: ports >Synopsis: [patch] net/vnstat add rc script >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Mon Jun 03 20:30:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Mark Felder >Release: >Organization: >Environment: >Description: -add rc script -run as non-root user -gd LIB_DEPENDS fixed to not require version .4 of library and make portlint happy please add these users to UIDs and GIDs vnstat:*:284:284::0:0:vnStat Network Monitor:/nonexistent:/usr/sbin/nologin vnstat:*:284: >How-To-Repeat: >Fix: Patch attached with submission follows: Index: Makefile =================================================================== --- Makefile (revision 319795) +++ Makefile (working copy) @@ -3,7 +3,7 @@ PORTNAME= vnstat PORTVERSION= 1.11 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= net MASTER_SITES= http://humdi.net/vnstat/ \ http://mirror.mcx2.org/ @@ -15,11 +15,18 @@ LDFLAGS="-L${LOCALBASE}/lib" INSTALL_TARGET= bsdinstall +USE_RC_SUBR= vnstat + +USERS= vnstat +GROUPS= vnstat + MAN1= vnstat.1 vnstatd.1 MAN5= vnstat.conf.5 MANCOMPRESSED= yes PORTDOCS= README INSTALL_BSD UPGRADE vnstat-cron SUB_FILES= pkg-message +SUB_LIST= USERS=${USERS} \ + GROUPS=${GROUPS} # will compile with image output OPTIONS_DEFINE= GUI DOCS @@ -34,7 +41,7 @@ etc/vnstat.conf.sample .if ${PORT_OPTIONS:MGUI} -LIB_DEPENDS+= gd.4:${PORTSDIR}/graphics/gd +LIB_DEPENDS+= gd:${PORTSDIR}/graphics/gd PLIST_SUB+= GUI="" MAN1+= vnstati.1 .else Index: files/vnstat.in =================================================================== --- files/vnstat.in (revision 0) +++ files/vnstat.in (working copy) @@ -0,0 +1,31 @@ +#!/bin/sh +# Created by: Mark Felder +# $FreeBSD$ + +# PROVIDE: vnstat +# REQUIRE: LOGIN +# KEYWORD: shutdown + +# Add the following line to /etc/rc.conf to enable vnstat: +# +# vnstat_enable="YES" +# vnstat_flags="-d -p ${vnstat_pidfile} --config %%PREFIX%%/etc/vnstat.cfg" +# vnstat_pidfile="/var/run/vnstat/vnstat.pid" + +. /etc/rc.subr + +name=vnstat +rcvar=vnstat_enable +load_rc_config $name + +vnstat_enable=${vnstat_enable-"NO"} +vnstat_pidfile=${vnstat_pidfile-"/var/run/vnstat/vnstat.pid"} +vnstat_flags=${vnstat_flags-"-d -p ${vnstat_pidfile} --config %%PREFIX%%/etc/vnstat.cfg"} +vnstat_user=${vnstat_user-"%%USERS%%"} +vnstat_group=${vnstat_group-"%%GROUPS%%"} + +command="%%PREFIX%%/bin/vnstatd" +command_args="${vnstat_flags}" +pidfile="${vnstat_pidfile}" + +run_rc_command "$1" >Release-Note: >Audit-Trail: >Unformatted: