Date: Thu, 21 Jul 2011 22:31:41 +0200 From: Koop Mast <kwm@rainbow-runner.nl> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: x11@FreeBSD.org, Robert Noland <rnoland@FreeBSD.org> Subject: Re: Simplify relative path in libGLU/Makefile Message-ID: <1311280301.2108.2.camel@crashalot.rainbow-runner.nl> In-Reply-To: <alpine.LNX.2.00.1107111034480.3864@gerinyyl.fvgr> References: <alpine.LSU.1.99.1005222044530.26362@acrux.dbai.tuwien.ac.at> <4BFA8A71.5000304@FreeBSD.org> <alpine.LNX.2.00.1105221547430.3210@gerinyyl.fvgr> <alpine.LNX.2.00.1107111034480.3864@gerinyyl.fvgr>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2011-07-11 at 10:37 +0200, Gerald Pfeifer wrote:
> Hi there,
>
> On Sun, 22 May 2011, Gerald Pfeifer wrote:
> > The usecase here is where someone checks out individual ports as
> > opposed to the entire tree or subtrees and builds them.
> >
> > This works very fine in general, there are but one or two ports
> > where this fails for me. graphics/libGLU is one of them.
> >
> >
> > I am pretty convinced my patch is not less correcty technically,
> > but rather more. It works both with a full ports checkout, and
> > the scenario I describe below.
>
> how about this patch? I did not see a response and would like to
> commit if there are no objections.
>
> Gerald @FreeBSD.org
I was going to decline, but a quick check of the ports tree shows that
both are used. I don't know which of the two is "correct", so with my
x11@ hat on I don't have a objection...
-Koop
> Index: Makefile
> ===================================================================
> RCS file: /home/pcvs/ports/graphics/libGLU/Makefile,v
> retrieving revision 1.14
> diff -u -r1.14 Makefile
> --- Makefile 25 Feb 2011 16:52:06 -0000 1.14
> +++ Makefile 11 Jul 2011 08:35:13 -0000
> @@ -19,5 +19,5 @@
> ${INSTALL_DATA} ${WRKSRC}/include/GL/glu*.h ${PREFIX}/include/GL/
> cd ${WRKSRC}/src/glu; ${GMAKE} install
>
> -.include "${.CURDIR}/../../graphics/libGL/bsd.mesalib.mk"
> +.include "${.CURDIR}/../libGL/bsd.mesalib.mk"
> .include <bsd.port.mk>
>
> _______________________________________________
> freebsd-x11@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-x11
> To unsubscribe, send any mail to "freebsd-x11-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1311280301.2108.2.camel>