From owner-cvs-all Wed Feb 6 15:45:29 2002 Delivered-To: cvs-all@freebsd.org Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.139.170]) by hub.freebsd.org (Postfix) with ESMTP id 9EA3637B421; Wed, 6 Feb 2002 15:45:19 -0800 (PST) Received: (from uucp@localhost) by storm.FreeBSD.org.uk (8.11.6/8.11.6) with UUCP id g16NjIc72124; Wed, 6 Feb 2002 23:45:18 GMT (envelope-from mark@grondar.za) Received: from greenpeace.grondar.org (greenpeace [192.168.42.2]) by gratis.grondar.org (Postfix) with ESMTP id 23CB15A; Wed, 6 Feb 2002 23:42:10 +0000 (GMT) Received: from grondar.za (localhost [127.0.0.1]) by greenpeace.grondar.org (8.11.6/8.11.6) with ESMTP id g16Ng1s34852; Wed, 6 Feb 2002 23:42:01 GMT (envelope-from mark@grondar.za) Message-Id: <200202062342.g16Ng1s34852@greenpeace.grondar.org> To: Dag-Erling Smorgrav Cc: current@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: Not committing WARNS settings... References: In-Reply-To: ; from Dag-Erling Smorgrav "06 Feb 2002 23:58:45 +0100." Date: Wed, 06 Feb 2002 23:41:56 +0000 From: Mark Murray Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > "David O'Brien" writes: > > Well... it would be nice if people would do CORRECT fixes. From > > some things DES was saying, people are making some really stupid "fixes" > > just to quite warnings. Esp. WRT const. > > Yes, the YP code is full of strdup()s that have no purpose other than > to silence const warnings, and the allocated memory is never freed - > nor is the return value from strdup() checked. Some strdup()s are ok. if they are definitely one-offs, then they are no worse than "char foo[BAR]" for some value of BAR. Others can be downright evil. M -- o Mark Murray \_ FreeBSD Services Limited O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message