From owner-freebsd-python@FreeBSD.ORG Tue Oct 2 18:12:48 2012 Return-Path: Delivered-To: python@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9E8731065672; Tue, 2 Oct 2012 18:12:48 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id BB9428FC08; Tue, 2 Oct 2012 18:12:47 +0000 (UTC) Received: by bkcjf20 with SMTP id jf20so4709685bkc.13 for ; Tue, 02 Oct 2012 11:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=7ntFSqDAcAy99cyEbjyw9j7KwBScwW4RqXXag4ZDCPs=; b=p/kVmfsPHnrDLxr3Y773uKFmBrh8H1Ujt04IjGgtKhbB+YaCEAi1sjVkxydB2Jr7t/ xn+YM2HGfk1g1dVz6JV225NNCRPzUdae8FRh4KGUnd89eXfva3iVzw/HAAYoSzm1jfoG +EvSdrKvNILEHYusjm1ZKHi8FMoGUasQh6VXFA5ZwY0zxdJMzlkhdgo316G4RLgU6uYQ NjGGM9IiAAmoKwNDeMizpiIPYOwrf+K8wX8ql3ZCPm/nhVkNUOs4iE+vYVRI2AO4qWXd dDytFZHrABerNC+qlk8PemXtyJCwL5mQmiE8z/MA4W4PxzLz06jcuSy3zEddo3b35pbw Q0fQ== MIME-Version: 1.0 Received: by 10.204.128.201 with SMTP id l9mr6908206bks.66.1349201566382; Tue, 02 Oct 2012 11:12:46 -0700 (PDT) Received: by 10.204.50.197 with HTTP; Tue, 2 Oct 2012 11:12:46 -0700 (PDT) Received: by 10.204.50.197 with HTTP; Tue, 2 Oct 2012 11:12:46 -0700 (PDT) In-Reply-To: <506B2A7C.5060301@yandex.ru> References: <50698A96.4000301@yandex.ru> <20121001161037.Horde.w6rVCKGZi1VQaaRdcWmiv-A@webmail.df.eu> <5069DB04.5080806@yandex.ru> <20121001181100.GA90625@FreeBSD.cs.nctu.edu.tw> <506B2A7C.5060301@yandex.ru> Date: Tue, 2 Oct 2012 19:12:46 +0100 Message-ID: From: Chris Rees To: Ruslan Mahmatkhanov Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Marcus von Appen , python , Li-Wen Hsu Subject: Re: Python distribution: switching to tar.xz X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2012 18:12:48 -0000 On 2 Oct 2012 18:55, "Ruslan Mahmatkhanov" wrote: > > Li-Wen Hsu wrote on 01.10.2012 22:11: > >> On Mon, Oct 01, 2012 at 22:03:48 +0400, Ruslan Mahmatkhanov wrote: >>> >>> Li-Wen Hsu wrote on 01.10.2012 21:51: >>>> >>>> >>>> EXTRACT_SUFX?= .tgz >>>> PYTHON_DISTFILE= Python-${PYTHON_PORTVERSION:S/.rc/rc/}}${EXTRACT_SUFX} >>> >>> >>> Yes, I also bow to this option. >>> >>>> then we can define USE_XZ= yes in the ports we want to use xz >>>> distfile, which handles >>>> ${EXTRACT_SUFX} and ${EXTRACT_DEPENDS} correctly. After python26 decommission, >>>> we can even move this into bsd.python.mk >>> >>> >>> python26 distributes in tar.xz too [1]. Or you meant something other? >>> >>> Ok, so I get the point. I'll prepare an patch that make ${EXTRACT_SUFX} >>> redefinable for python ports, so we can gradually switch all this ports >>> to xz. Thanks Marcus and Li-Wen. >>> >>> [1] http://www.python.org/ftp/python/2.6.8/Python-2.6.8.tar.xz >>> >> >> Oh I was not aware that, I just did not see XZ information at: >> >> http://python.org/download/releases/2.6.8/ >> >> So maybe we can simply put USE_XZ= yes in bsd.python.mk now. > > > Ok, here is the patch [1]. Unfortunately, we can't just include USE_XZ into bsd.python.mk because this will affect *all* the ports, that define USE_PYTHON in their Makefile's. I can't think a way how to (nicely) apply USE_XZ to limited set of ports inside of bsd.python.mk. Using tar.xz instead of .tgz in ${PYTHON_DISTFILE} will not work on systems, that lacks xz in a base system and I dislike the duplication of USE_XZ internals in bsd.python.mk for them. > > So this patch just replaces .tgz with ${EXTRACT_SUFX} and USE_XZ is used in individual python ports. I did some test builds of python and it's slaves (py-sqlite3, py-bdsdb, py-gdbm, py-tkinter) and everything seems fine. I also diffed all the four pairs tgz/tar.xz of each python version - and, as it was expected, their content is equal. > > Any objections, suggestions etc? > > [1] http://people.freebsd.org/~rm/tgz-to-tx-conversion.diff.txt My suggestion is to do it :) Thanks for doing the work. Chris