From owner-freebsd-current@FreeBSD.ORG Fri Jan 22 10:45:06 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BDE5A106566B for ; Fri, 22 Jan 2010 10:45:06 +0000 (UTC) (envelope-from peterjeremy@acm.org) Received: from mail12.syd.optusnet.com.au (mail12.syd.optusnet.com.au [211.29.132.193]) by mx1.freebsd.org (Postfix) with ESMTP id 4DCF38FC08 for ; Fri, 22 Jan 2010 10:45:05 +0000 (UTC) Received: from server.vk2pj.dyndns.org (c122-106-232-148.belrs3.nsw.optusnet.com.au [122.106.232.148]) by mail12.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id o0MAj3Wa026532 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 22 Jan 2010 21:45:04 +1100 X-Bogosity: Ham, spamicity=0.000000 Received: from server.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by server.vk2pj.dyndns.org (8.14.3/8.14.3) with ESMTP id o0MAiwnE032058; Fri, 22 Jan 2010 21:44:58 +1100 (EST) (envelope-from peter@server.vk2pj.dyndns.org) Received: (from peter@localhost) by server.vk2pj.dyndns.org (8.14.3/8.14.3/Submit) id o0MAiwUs032057; Fri, 22 Jan 2010 21:44:58 +1100 (EST) (envelope-from peter) Date: Fri, 22 Jan 2010 21:44:58 +1100 From: Peter Jeremy To: Tobias Rehbein Message-ID: <20100122104457.GB31243@server.vk2pj.dyndns.org> References: <20100121210523.GA1442@sushi.pseudo.local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="b5gNqxB1S1yM7hjW" Content-Disposition: inline In-Reply-To: <20100121210523.GA1442@sushi.pseudo.local> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.20 (2009-06-14) Cc: freebsd-current@freebsd.org Subject: Re: [patch] Let indent(1) handle widecharacter literals correctly X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jan 2010 10:45:06 -0000 --b5gNqxB1S1yM7hjW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2010-Jan-21 22:05:23 +0100, Tobias Rehbein wrote: >I am not subscribed to this list, so please answer me off-list or cc me. > >I noticed that indent(1) handles widecharacter literals (e.g. L'c' or L"st= ring") >incorrectly. indent(1)s parser treats the L-prefix and the quoted part as >seperate tokens. The result is: > > L'c' -> L 'c' > L"string" -> L "string" Thank you for noticing that. Can you please submit your patch as a PR so it doesn't get lost (send-pr(1)). >Of course this breaks any code using widecharacters. As I use indent(1) qu= ite >extensively I decided to fix this issue. As this is my first patch against= the >FreeBSD user land feel free to comment! I don't know indent(1) well enough to comment on the functional aspects but there are some style issues with the patch. Two lines are longer than 80 characters and the indenting doesn't align - see style(9). --=20 Peter Jeremy --b5gNqxB1S1yM7hjW Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAktZgakACgkQ/opHv/APuIfI8ACgo7h/ZIyVAjDIChfqVJK1ZDBb 8KEAn2T3QixIbxZpNgRPd9kGhXn9j+rT =2TJK -----END PGP SIGNATURE----- --b5gNqxB1S1yM7hjW--