Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 10 Apr 2023 04:16:51 GMT
From:      Zhenlei Huang <zlei@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: bab5ce8deafb - stable/13 - ifconfig: Fix configuring if_bridge with additional operating parameters
Message-ID:  <202304100416.33A4GpA2039682@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by zlei:

URL: https://cgit.FreeBSD.org/src/commit/?id=bab5ce8deafb00683fb8319208750981e68d309c

commit bab5ce8deafb00683fb8319208750981e68d309c
Author:     Zhenlei Huang <zlei@FreeBSD.org>
AuthorDate: 2023-04-07 14:25:41 +0000
Commit:     Zhenlei Huang <zlei@FreeBSD.org>
CommitDate: 2023-04-10 04:15:05 +0000

    ifconfig: Fix configuring if_bridge with additional operating parameters
    
    For clone create and rename operations, the interface name get back can be
    different from the one passed to ioctl(). Use the interface name we get back
    so that ifconfig will not return unexpected ENXIO.
    
    PR:             270618
    Reviewed by:    kp
    MFC after:      3 days
    Differential Revision:  https://reviews.freebsd.org/D39396
    
    (cherry picked from commit 09e5e3d598604167c1fb05e5cd0f41ed83314517)
---
 sbin/ifconfig/ifbridge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sbin/ifconfig/ifbridge.c b/sbin/ifconfig/ifbridge.c
index 2bd9c96f2489..3a78b068eb5d 100644
--- a/sbin/ifconfig/ifbridge.c
+++ b/sbin/ifconfig/ifbridge.c
@@ -91,7 +91,7 @@ do_cmd(int sock, u_long op, void *arg, size_t argsize, int set)
 
 	memset(&ifd, 0, sizeof(ifd));
 
-	strlcpy(ifd.ifd_name, ifr.ifr_name, sizeof(ifd.ifd_name));
+	strlcpy(ifd.ifd_name, name, sizeof(ifd.ifd_name));
 	ifd.ifd_cmd = op;
 	ifd.ifd_len = argsize;
 	ifd.ifd_data = arg;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202304100416.33A4GpA2039682>