From owner-cvs-src@FreeBSD.ORG Fri Mar 28 19:03:14 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2798337B401; Fri, 28 Mar 2003 19:03:14 -0800 (PST) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 77F8943F75; Fri, 28 Mar 2003 19:03:12 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id OAA14783; Sat, 29 Mar 2003 14:02:55 +1100 Date: Sat, 29 Mar 2003 14:02:55 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?= In-Reply-To: Message-ID: <20030329134320.C9370@gamplex.bde.org> References: <20030327180247.D1825@gamplex.bde.org> <20030327212647.GA64029@walton.maths.tcd.ie> <20030328174850.M6165@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE cc: David Malone cc: src-committers@FreeBSD.org cc: Nate Lawson cc: cvs-src@FreeBSD.org cc: Mike Silbersack cc: cvs-all@FreeBSD.org Subject: Re: Checksum/copy X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Mar 2003 03:03:16 -0000 On Fri, 28 Mar 2003, Dag-Erling [iso-8859-1] Sm=F8rgrav wrote: > Bruce Evans writes: > > Instead of fixing the comparison and any other logic bugs, I rewrote th= e > > function using orl instead of scasl, and simpler logic (ignore the chan= ges > > for the previous function in the same hunk). > > Could you please commit this? Nothing uses it, so it won't break > anything, but it'll make testing and benchmarking easier for > interested parties. Er, it is used (in pmap.c). I recently learned that makeworld is an interesting benchmark for zeroing pages (all %times on a system with 1 Athlon and 1GB of memory): - makeworld spends at least 3-5% of its time zeroing pages - turning off vm.idlezero_enable increases makeworld time by 1-2% and moves the place where the zeroing is done significantly. With vm.idlezero_enable off, most of the idle zeroing is done in process context and gets charged to makeworld; otherwise it is done in the pagezero task and gets charged to that. Most but not all of the time spent in the pagezero task is "free", and we lose the 1-2% by doing all zeroing in process context. - SCHED_ULE breaks scheduling of idleprio processes. This results in pagezero being too active. It costs 1-2% instead of saving 1-2%. Bruce