From owner-svn-src-all@freebsd.org Tue Aug 18 14:14:21 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1D8DA3BDBBD; Tue, 18 Aug 2020 14:14:21 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWCb00xJPz47Bn; Tue, 18 Aug 2020 14:14:19 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x82c.google.com with SMTP id x12so15209108qtp.1; Tue, 18 Aug 2020 07:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Q0MughOW+7ToEk9Pd16Dy1xfdyxVd3vcaj3GzqLNOe4=; b=m3GPYg4cO/QX+LuzrQNpdF5FsH2idvNZucgiaFJtjclNZQ6ip44JvtQSYufoLGo+Wv xoHfGUU+AfjeI/DiGRWMSqasMpcrmNtV8MY17Y62I2zNUkFiztr9/tvmnvKYVArPNnrX Hocs1vWGAdI5/9HVwt0LnffvwiuhhNelmtO2jxMrDLXToZ8qJwEWTXK9UO4S/2/abJW7 5r8jjrz0t8JWrZJ+Vu3APtXrcr+7hPDaewDeh6vHlHZF4DWooovDVSykcMpUwCjgWK8B taXvHrkJx3Gk5fosSgWtZilOEWi2/0/0w4FY1+DcHdJNcPpyUiHCTnpWAGoklBS60lWb xTOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=Q0MughOW+7ToEk9Pd16Dy1xfdyxVd3vcaj3GzqLNOe4=; b=XI8uD1Yf1A6LZz9lVzNB9QARBnDVdRuOthPcMGV63Qx80lj7O7HKzLQvEzkKnzWVJY 2azUlPixgafTsKaUQX9C20vxsy1K2gU28pjyFTbPnY4GuV/cyvBQe46ET2Ka6hAKLNUw NoHVAq1odq8OcQrfaqiN01jxB1HjFB6cZAOG3L00a3L94ilYbjAiEQhozgLeT2I5yM1H C8BSzP7Vvdcgg6pgzbsP0jIzwN54zT4PxUETRFjoNZ/cKcGALf+bAtORmPB+pkcJQdmz C3vYwZCSYCMFprHAmauVHwPTw740nT17Jx/0gpM/kDyqdcpD4nKnFStDYSFHQiPZhpXT Mflw== X-Gm-Message-State: AOAM530SsBpy7jyKkdNHscQqXJZO5vGICmJTDt9s/pWNrQU1rIUQ3Pxa WzTzXznpIpg4loJbkmxUF8qEGLfjo8Q= X-Google-Smtp-Source: ABdhPJyqajFuP0EXfwPRGL89z3ja8O3lq9npAFnmD9xfNayAC9VDRk6CAzzsNp+itmUGBbaNp4KDwg== X-Received: by 2002:ac8:51c1:: with SMTP id d1mr18141373qtn.385.1597760057577; Tue, 18 Aug 2020 07:14:17 -0700 (PDT) Received: from raichu (toroon0560w-lp130-08-67-71-176-35.dsl.bell.ca. [67.71.176.35]) by smtp.gmail.com with ESMTPSA id t25sm22947294qtp.22.2020.08.18.07.14.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2020 07:14:16 -0700 (PDT) Sender: Mark Johnston Date: Tue, 18 Aug 2020 10:14:14 -0400 From: Mark Johnston To: Andriy Gapon Cc: Gleb Smirnoff , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364310 - in head/sys: kern vm Message-ID: <20200818141414.GC28906@raichu> References: <202008171537.07HFb8a6058296@repo.freebsd.org> <8f9d96f9-ecbb-1ed9-5347-b4b25662a6a2@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8f9d96f9-ecbb-1ed9-5347-b4b25662a6a2@FreeBSD.org> X-Rspamd-Queue-Id: 4BWCb00xJPz47Bn X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 14:14:21 -0000 On Tue, Aug 18, 2020 at 01:03:25AM +0300, Andriy Gapon wrote: > On 17/08/2020 18:37, Gleb Smirnoff wrote: > > Author: glebius > > Date: Mon Aug 17 15:37:08 2020 > > New Revision: 364310 > > URL: https://svnweb.freebsd.org/changeset/base/364310 > > > > Log: > > With INVARIANTS panic immediately if M_WAITOK is requested in a > > non-sleepable context. Previously only _sleep() would panic. > > This will catch misuse of M_WAITOK at development stage rather > > than at stress load stage. > > > > Reviewed by: markj > > Differential Revision: https://reviews.freebsd.org/D26027 > > I think that there is going to be a lot of fallout from this. > Will you handle it? > A warning from WITNESS is one thing, a panic is another. Indeed, based on a few reports from freebsd-current I reverted the commit. It seems there are a number of places in CAM that will require modification, particularly in async event handling. Note that CAM doneq threads execute handlers with TD_NO_SLEEPING.