Date: Fri, 24 Sep 2010 08:39:53 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Stanislav Sedov <stas@FreeBSD.org> Cc: Doug Barton <dougb@FreeBSD.org>, cvs-all@freebsd.org, ports-committers@freebsd.org, Andrej Zverev <az@freebsd.org>, cvs-ports@freebsd.org, "Philip M. Gollucci" <pgollucci@freebsd.org>, "Sergey A. Osokin" <osa@FreeBSD.org> Subject: Re: cvs commit: ports/archivers/p5-Archive-Any pkg-plist ports/archivers/p5-Archive-SimpleExtractor pkg-plist ports/archivers/p5-Compress-LZF pkg-plist ports/archivers/p5-Compress-LZO pkg-plist ports/archivers/p5-Compress-LZW pkg-plist ports/archiver Message-ID: <20100924083953.GA12164@FreeBSD.org> In-Reply-To: <20100924004958.1fb10eeb.stas@FreeBSD.org> References: <AANLkTi=9ZfAhdkAZ5dhXebM=4dpnnmC83Awg9O6EeED9@mail.gmail.com> <4C9C4CDB.9000706@FreeBSD.org> <20100924071832.GB72615@FreeBSD.org> <4C9C52E0.2040507@FreeBSD.org> <20100924004958.1fb10eeb.stas@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 24, 2010 at 12:49:58AM -0700, Stanislav Sedov wrote: > If there going to be a standard, it should be documented first. From my > POV I can see a benefit of having a @comment in pkg-plist, as it allows > one to find out what revision this file was. Having RCS ident string embedded into a file generally considered good thing to have, true. However, we generally omit one from files like distinfo or pkg-plist because of the low volatile nature thereof. While having it in Makefile header is certainly good and useful thing (e.g. it is used in pointyhat build logs), instrumenting plist with @comment can be controversial. Since relatively low number of pkg-plist files use it, I can understand why Philip decided to drop it. (I'm talking only about technical side of the issue; lack of review is different thing.) I also support the idea of documenting either way after thorough review by all interested parties and adding it to PH/portlint(1). > Or changing all ports with dynamic pkg-lists to use static one just > because most ports do this. Bad example. :-) Both dynamic and static package lists are useful, as both have their strong and weak sides (and benefits in questions here are a lot more substantial than availability of ident information). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100924083953.GA12164>