From owner-p4-projects@FreeBSD.ORG  Mon Oct 16 21:37:27 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 8B39516A415; Mon, 16 Oct 2006 21:37:27 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4C93F16A412;
	Mon, 16 Oct 2006 21:37:27 +0000 (UTC)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.sick.ru (cell.sick.ru [217.72.144.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3AC7543D70;
	Mon, 16 Oct 2006 21:37:19 +0000 (GMT)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.sick.ru (glebius@localhost [127.0.0.1])
	by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k9GLbInj031852
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 17 Oct 2006 01:37:18 +0400 (MSD)
	(envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
	by cell.sick.ru (8.13.4/8.13.1/Submit) id k9GLbIuh031851;
	Tue, 17 Oct 2006 01:37:18 +0400 (MSD)
	(envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.sick.ru: glebius set sender to
	glebius@FreeBSD.org using -f
Date: Tue, 17 Oct 2006 01:37:18 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Paolo Pisati <piso@FreeBSD.org>
Message-ID: <20061016213718.GS59833@FreeBSD.org>
References: <200610162129.k9GLTTAF086207@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <200610162129.k9GLTTAF086207@repoman.freebsd.org>
User-Agent: Mutt/1.5.6i
Cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 108000 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Oct 2006 21:37:27 -0000

On Mon, Oct 16, 2006 at 09:29:29PM +0000, Paolo Pisati wrote:
P> Change 108000 by piso@piso_newluxor on 2006/10/16 21:28:34
P> 
P> 	Move nat locking from private nat_chain_rwl to layer3_chain rwl.
P> +#define	NAT_WLOCK_ASSERT(_chain) IPFW_WLOCK_ASSERT(_chain)
P> +#define NAT_RLOCK(p) IPFW_RLOCK(p)
P> +#define NAT_RUNLOCK(p) IPFW_RUNLOCK(p)
P> +#define NAT_WLOCK(p) IPFW_WLOCK(p)
P> +#define NAT_WUNLOCK(p) IPFW_WUNLOCK(p)

It is an obfuscation of the code. Why do we need to have two words
doing the same instead of one?

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE