From owner-svn-src-all@FreeBSD.ORG Wed May 13 00:29:47 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D34FC9E9; Wed, 13 May 2015 00:29:47 +0000 (UTC) Received: from mail.strugglingcoder.info (strugglingcoder.info [65.19.130.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BE8B71C96; Wed, 13 May 2015 00:29:47 +0000 (UTC) Received: from localhost (unknown [10.1.1.3]) (Authenticated sender: hiren@strugglingcoder.info) by mail.strugglingcoder.info (Postfix) with ESMTPSA id 95DBA110787; Tue, 12 May 2015 17:29:41 -0700 (PDT) Date: Tue, 12 May 2015 17:29:41 -0700 From: Hiren Panchasara To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r281838 - head/sys/dev/e1000 Message-ID: <20150513002941.GA10967@strugglingcoder.info> References: <201504212024.t3LKOG3N073010@svn.freebsd.org> <20150421220550.GA28632@strugglingcoder.info> <20150422193604.GF28632@strugglingcoder.info> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline In-Reply-To: <20150422193604.GF28632@strugglingcoder.info> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 May 2015 00:29:47 -0000 --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 04/22/15 at 12:36P, Hiren Panchasara wrote: > On 04/21/15 at 03:05P, Hiren Panchasara wrote: > > On 04/21/15 at 08:24P, Hiren Panchasara wrote: > > > Author: hiren > > > Date: Tue Apr 21 20:24:15 2015 > > > New Revision: 281838 > > > URL: https://svnweb.freebsd.org/changeset/base/281838 > > >=20 > > > Log: > > > For igb(4), when we are doing multiqueue, we are all setup to have = full 32bit > > > RSS hash from the card. We do not need to hide that under "ifdef RS= S" and should > > > expose that by default so others like lagg(4) can use that and avoi= d hashing the > > > traffic by themselves. > > > While here, improve comments and get rid of hidden/unimplemented RS= S support > > > code for UDP. > > > =20 > > > Differential Revision: https://reviews.freebsd.org/D2296 > > > Reviewed by: jfv, erj > > > Discussed with: adrian > > > Sponsored by: Limelight Networks > > >=20 > > > Modified: > > > head/sys/dev/e1000/if_igb.c > >=20 > > I intend to MFC this in a week or so. But for that, I'd have to first > > MFC a part of https://svnweb.freebsd.org/base?view=3Drevision&revision= =3D268028 > > which sets rss hash types. >=20 > Apparently another missing MFC is r275358. I'll work on them. So, here is the patch that I intend to commit to stable/10: https://people.freebsd.org/~hiren/patches/igb_flowid_mfc.patch RSS is not (yet) ready to be brought back into stable/10 so for now I am only exposing full 32bit flowid and we will still return flowtype OPAQUE. cheers, Hiren --AhhlLboLdkugWU4S Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQF8BAEBCgBmBQJVUpr1XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lt4kH/Ax/KydpXQctbO89wMU9CXWg ZM/R5SZRgc6LAnj/fUYxRfVSPbu0Ibr5QU2prGy7oeCW9MTfaXWKmdcD0JUR3vaM CQwHvn5odi+pfL+GOHj0ntck92cUJdqTucQ1croOVQR3Kv3Ac1Tneon1Ik03uNE4 tLRc//muZOgjZa2TRgw0Z879uZytgFCC9AbS1uqK2cqPhQjbgO6qJVyO+/wdHA26 vkZUJkHwLZ3jHcygF8vOqErxB2SxUpz0FOdyO3QiJRrsnE57cPWWy1wNegRUuFl6 Ut/vsPW+gHHmXE6vhkxUE0d1LSCyVzxL0hGpb484/hPQNWZ1I5n7FY5qQu6rFgc= =YoDI -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S--