From owner-freebsd-bugs@FreeBSD.ORG Thu May 15 05:20:04 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C3D851065679 for ; Thu, 15 May 2008 05:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B42D88FC17 for ; Thu, 15 May 2008 05:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m4F5K3qD008220 for ; Thu, 15 May 2008 05:20:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m4F5K3P6008219; Thu, 15 May 2008 05:20:03 GMT (envelope-from gnats) Date: Thu, 15 May 2008 05:20:03 GMT Message-Id: <200805150520.m4F5K3P6008219@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Yar Tikhiy" Cc: Subject: Re: kern/122833: [snapshots] [patch] mountd fails on nmount() after UFS snapshot creation with mount X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Yar Tikhiy List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 May 2008 05:20:04 -0000 The following reply was made to PR kern/122833; it has been noted by GNATS. From: "Yar Tikhiy" To: "Craig Rodrigues" Cc: "Jaakko Heinonen" , bug-followup@freebsd.org, "Ga??l Roualland" , leon.kos@lecad.fs.uni-lj.si, rodrigc@freebsd.org Subject: Re: kern/122833: [snapshots] [patch] mountd fails on nmount() after UFS snapshot creation with mount Date: Thu, 15 May 2008 08:42:35 +0400 On Thu, May 15, 2008 at 1:01 AM, Craig Rodrigues wrote: > On Wed, May 14, 2008 at 06:56:40PM +0000, Craig Rodrigues wrote: >> That fix is wrong. The better fix would be to come up >> with a function that traverses a vfs_optlist and deletes a string >> option from the list. Something like: > > Actually we have such a function. We need to do to the "snapshot" option > what we do to the "export" option in sys/kern/vfs_export.c. And "update" is also on the waiting list for such handling. -- Yar