From owner-freebsd-hackers@FreeBSD.ORG Wed Dec 4 21:19:04 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CF0AC3D4 for ; Wed, 4 Dec 2013 21:19:04 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 645B411F1 for ; Wed, 4 Dec 2013 21:19:04 +0000 (UTC) Received: from mandree.no-ip.org ([78.49.75.28]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MbxJ8-1W4KnI0CGs-00JGiI for ; Wed, 04 Dec 2013 22:19:02 +0100 Received: from [IPv6:::1] (localhost6.localdomain6 [IPv6:::1]) by apollo.emma.line.org (Postfix) with ESMTP id D831E23D02A for ; Wed, 4 Dec 2013 22:19:00 +0100 (CET) Message-ID: <529F9C44.3070202@gmx.de> Date: Wed, 04 Dec 2013 22:19:00 +0100 From: Matthias Andree User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: freebsd-hackers@freebsd.org Subject: Re: Kind of hacky fix for banshee-2.6.0 References: <3074012.QmsohyHcnK@hactar> <2093792.KXDdxCWCWG@hactar> <1386179105.17871.55518481.669547E0@webmail.messagingengine.com> <1687534.6K1SDGFtbY@hactar> In-Reply-To: <1687534.6K1SDGFtbY@hactar> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Onr5+/05TKtNxKeVaaGcP7PdHSky4KfwJpV6cjTRdbpzfaUfI3J Qvk/ylbP/RYC4+ifNgWUL/7BU4aBlE/oYHrM4vNGjNHLh+E9OPWW5Lsa/Aca5W/mBP+SLWk NqDgUQOOy2Rs2ZYurWsPk+D9j27xvPEDQHKlK4Xk3KMstfNeVceGgJQ66JzOFECFmMKidXI mK08UR0qkMfBfczF72GnA== X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Dec 2013 21:19:04 -0000 Am 04.12.2013 21:37, schrieb Stefan Wendler: > On Wednesday 04 December 2013 11:45:05 Mark Felder wrote: >> >> I have a build dependency issue so I can't even get my poudriere to >> build banshee and test further. I'll poke at it again later this week if >> I get a chance. Feel free to bounce questions off us in IRC as well. > I will do that. > > But I have a general question. Is it even possible to do the following within > REINPLACE_CMD: insert a line, if it is not present? Because the > ASSEMBLY_BUILD_FLAGS variable has to be in almost all Makefile.in files. And > there are alot. Yes, but code like that starts getting cumbersome. You might get away with (sorry, I got to quote this to cheat my mailer not to word-wrap): > for i in $(${FIND} ${WRKSRC} -name 'Makefile.*'); do ; \ > if ${GREP} -q "ASSEMBLY_BUILD_FLAGS" ; then \ > ${REINPLACE_CMD} -E 's|ASSEMBLY_BUILD_FLAGS = -unsafe|ASSEMBLY_BUILD_FLAGS = -unsafe -sdk:4|' $$i ; \ > else ${REINPLACE_CMD} -E "1iASSEMBLY_BUILD_FLAGS=-unsafe -sdk:4" $$i ; fi; \ > done Where 1i is the magic incantation to insert on (i. e. before) line 1. If you have a common anchor text, you can replace the 1 by /uniquetext/, as in: ${REINPLACE_CMD} -E '/^MAGICPLACE/iASSEMBLY_BUILD_FLAGS=...' $$i