Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 11 Apr 2012 04:15:30 +0400 (MSK)
From:      Dmitry Marakasov <amdmi3@amdmi3.ru>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        lua@FreeBSD.org, mandree@FreeBSD.org
Subject:   ports/166832: [PATCH] lang/lua: unbreak support for several important functions
Message-ID:  <20120411001530.2309E474@hades.panopticon>
Resent-Message-ID: <201204110020.q3B0KEDJ071314@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         166832
>Category:       ports
>Synopsis:       [PATCH] lang/lua: unbreak support for several important functions
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 11 00:20:14 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Dmitry Marakasov
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD hades.panopticon 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 10 01:33:18 MSK 2012
>Description:
This change:
http://www.freebsd.org/cgi/cvsweb.cgi/ports/lang/lua/Makefile.diff?r1=1.47;r2=1.48

is
1) Not needed, as CFLAGS are passed via MAKE_ENV anyway
2) Makes lua's make not able to append CFLAGS with additional flags (namely -DLUA_USE_LINUX) which enables support for crucial features like readline, popen and posix support.

The patch attached reverts the change and thus fixes support for these functions in lua.

Port maintainer (lua@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_5 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:

--- lua-5.1.5_2.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/lang/lua/Makefile,v
retrieving revision 1.50
diff -u -u -r1.50 Makefile
--- Makefile	6 Apr 2012 17:50:44 -0000	1.50
+++ Makefile	11 Apr 2012 00:08:34 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	lua
 PORTVERSION=	5.1.5
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	lang
 MASTER_SITES=	http://www.lua.org/ftp/ \
 		ftp://ftp.ntua.gr/pub/lang/lua/ \
@@ -24,7 +24,6 @@
 USE_LDCONFIG=	yes
 MAKE_JOBS_SAFE=	yes
 MAKE_ENV=	LUA_SONAME="liblua-${LUA_VER}.so.${LUA_VER_SH}"
-MAKE_ARGS=	CFLAGS="${CFLAGS}"
 
 MAN1=		lua-${LUA_VER}.1 luac-${LUA_VER}.1
 DOCSDIR=	${PREFIX}/share/doc/${LUA_SUBDIR}
--- lua-5.1.5_2.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120411001530.2309E474>