From owner-cvs-all Thu Jan 17 9: 8:17 2002 Delivered-To: cvs-all@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 35F4137B404; Thu, 17 Jan 2002 09:08:09 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id g0HH84l26460; Thu, 17 Jan 2002 10:08:05 -0700 (MST) (envelope-from imp@village.org) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id g0HH83x94566; Thu, 17 Jan 2002 10:08:03 -0700 (MST) (envelope-from imp@village.org) Date: Thu, 17 Jan 2002 10:07:17 -0700 (MST) Message-Id: <20020117.100717.76575563.imp@village.org> To: bmah@FreeBSD.org Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, oberman@es.net Subject: Re: cvs commit: src/sys/dev/sio sio.c From: "M. Warner Losh" In-Reply-To: <200201171649.g0HGnOD23179@bmah.dyndns.org> References: <200201171616.g0HGGqn13750@freefall.freebsd.org> <200201171649.g0HGnOD23179@bmah.dyndns.org> X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <200201171649.g0HGnOD23179@bmah.dyndns.org> "Bruce A. Mah" writes: : If memory serves me right, Warner Losh wrote: : > imp 2002/01/17 08:16:52 PST : > : > Modified files: : > sys/dev/sio sio.c : > Log: : > While I'm not sure that I like the wording of the BIOS message in the : > previous commit, it should always print due to lack of {} around the : > second line in the if statement. The message should likely say : > something more like "There's no hardware responding at this IRQ. : > Device not present (or disbaled)," but that is too long. : : Pointy hat to: bmah : : I even tested this patch (I bet nobody's going to believe that one!), : and somehow missed the output in dmesg. :-( hehe. : > We generally : > don't give elementary advise in device driver messages anyway. Be : > that as it may, the problem with it printing all the time should be : > corrected. : : It's a support issue. I don't object real strongly to backing out the : "port may be disabled" message but the way that the sio probe claimed a : disabled port was really an 8250 was pretty bogus and has bitten a bunch : of people (me included). So I think that some form of the second hunk : of the patch should stay in. That part of the patch I have no problems with (it is correct, and the only slight bogon in it is that maybe the the hardware is at that address, but not a UART at all :-). It is the part that says that it may be disabled in the BIOS. That's only one of a long list of reasons... The SIO driver is used on non-intel hardware, and some of that hardware doesn't even have a BIOS in the traditional intel sense :-) Like I said, it was the wording of the message.... Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message