From nobody Wed Aug 17 13:33:54 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M78B04pZBz4ZTDX; Wed, 17 Aug 2022 13:34:00 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M789z6HxZz3DVF; Wed, 17 Aug 2022 13:33:59 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: by mail-ej1-f52.google.com with SMTP id tl27so24586590ejc.1; Wed, 17 Aug 2022 06:33:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc; bh=6m0fSVdEemYgqQA/KNyr5dLEdpt0JA4SShCn/UjdcUs=; b=OCSL9rCmiiBm4tZVWpe8uI/rvnAjnLw4HiOr1YMxPBxJouRxErzxcrgVrp+WQJ5IXV CkSCFrZqPLtzO3AynBpC53BJN1V/YEIjISI9NfdlwxVDFcvmGeMdSGcRa4dPVNW0ulIW kX7a7ioeNhDOpxFnVTGam7H8733QUmen0AnWyGOoG2DbPihUZoKE3OuJfqihCKyzo8ue /45yxOuULe50O5oKSAYPi4HqCrh7+hL3NtuwoRqWSDqKa0urKZGzFrywevYZfRk2k025 pN3MAsiyJAtNiuhPsDgi2nJlo2kRu+vs2XxN4oywiDwDAZaIm0Wg5c6iqs6joRnZUSob aiqQ== X-Gm-Message-State: ACgBeo3KhUBHlULfYek9oI56tNsGCYcTa1zoTrXHgjx9F4UZfVUjZNHg ikVFFkBb+3VcS+vo7fmMdk05wOXBqA4iedvt X-Google-Smtp-Source: AA6agR7vu+t9FSTsHyTbNKIM7oOcbuirz8D7cmZHuihuSp//7ZhpVnVDwgAhjTUUpNwAdMO70pUS0g== X-Received: by 2002:a17:907:7ea2:b0:731:3bb6:d45a with SMTP id qb34-20020a1709077ea200b007313bb6d45amr16760718ejc.524.1660743238202; Wed, 17 Aug 2022 06:33:58 -0700 (PDT) Received: from smtpclient.apple ([2a02:8109:8680:1304:6804:ed48:9a55:50b6]) by smtp.gmail.com with ESMTPSA id fq15-20020a1709069d8f00b007306a4ecc9dsm6867130ejc.18.2022.08.17.06.33.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Aug 2022 06:33:57 -0700 (PDT) From: Mateusz Piotrowski <0mp@FreeBSD.org> Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_D1204960-50CB-495A-BC4D-19B615AACE5D" List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: c9be47b34dd8 - main - rc: add ${name}_setup script support Date: Wed, 17 Aug 2022 15:33:54 +0200 In-Reply-To: <202208151442.27FEgjSd083060@gitrepo.freebsd.org> Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" To: Mariusz Zaborski , franco@opnsense.org References: <202208151442.27FEgjSd083060@gitrepo.freebsd.org> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Rspamd-Queue-Id: 4M789z6HxZz3DVF X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mpp302@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=mpp302@gmail.com X-Spamd-Result: default: False [-1.59 / 15.00]; SUBJECT_HAS_CURRENCY(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.997]; NEURAL_HAM_SHORT(-0.99)[-0.994]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[0mp@FreeBSD.org,mpp302@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; RWL_MAILSPIKE_GOOD(-0.10)[209.85.218.52:from]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; DMARC_NA(0.00)[freebsd.org]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCPT_COUNT_FIVE(0.00)[5]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_NEQ_ENVFROM(0.00)[0mp@FreeBSD.org,mpp302@gmail.com]; RCVD_COUNT_THREE(0.00)[3]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.218.52:from]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org] X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_D1204960-50CB-495A-BC4D-19B615AACE5D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hey, > On 15. Aug 2022, at 16:42, Mariusz Zaborski = wrote: >=20 > The branch main has been updated by oshogbo: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dc9be47b34dd847da1d4ab0feee4a6100= b2c5ea0d >=20 > commit c9be47b34dd847da1d4ab0feee4a6100b2c5ea0d > Author: Franco Fichtner > AuthorDate: 2022-08-15 14:41:31 +0000 > Commit: Mariusz Zaborski > CommitDate: 2022-08-15 14:43:12 +0000 >=20 > rc: add ${name}_setup script support >=20 > Run a service-based setup script before running the start command. > Useful for automatic configuration file generation. >=20 Couldn't this be achieved with NAME_prepend? Here=E2=80=99s an example: # sh -c 'test_prepend=3D"/bin/echo \"generating files\" &&=E2=80=9D;=20 . /etc/rc.subr; name=3Dtest;=20 rcvar=3Dtest_enable;=20 command=3D"/bin/echo=E2=80=9D;=20 command_args=3D"hello=E2=80=9D;=20 run_rc_command onestart=E2=80=99 The out will be: Starting test. generating files hello Best, Mateusz= --Apple-Mail=_D1204960-50CB-495A-BC4D-19B615AACE5D Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Hey,

On 15. Aug 2022, at 16:42, = Mariusz Zaborski <oshogbo@freebsd.org> wrote:

The = branch main has been updated by oshogbo:

URL:= https://cgit.FreeBSD.org/src/commit/?id=3Dc9be47b34dd847da1d4ab= 0feee4a6100b2c5ea0d

commit = c9be47b34dd847da1d4ab0feee4a6100b2c5ea0d
Author: =     Franco Fichtner <franco@opnsense.org>
AuthorDate: = 2022-08-15 14:41:31 +0000
Commit: =     Mariusz Zaborski <oshogbo@FreeBSD.org>
CommitDate: = 2022-08-15 14:43:12 +0000

=    rc: add ${name}_setup script support

   Run a service-based setup script before = running the start command.
   Useful for = automatic configuration file generation.


Couldn't = this be achieved with NAME_prepend? Here=E2=80=99s an = example:


# sh -c 'test_prepend=3D"/bin/echo \"generating = files\" &&=E2=80=9D; 
. /etc/rc.subr; = name=3Dtest; 
rcvar=3Dtest_enable; 
command=3D"/bin/echo=E2=80=9D; 
command_args=3D"hello=E2=80=9D; 
run_rc_command onestart=E2=80=99

The out will be:

Starting test.
generating files
hello


Best,
Mateusz
= --Apple-Mail=_D1204960-50CB-495A-BC4D-19B615AACE5D--