From owner-freebsd-bugs@FreeBSD.ORG  Sat Oct 10 19:50:02 2009
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8A5EA1065672
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 10 Oct 2009 19:50:02 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 7523D8FC0C
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 10 Oct 2009 19:50:02 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n9AJo2Re004349
	for <freebsd-bugs@freefall.freebsd.org>; Sat, 10 Oct 2009 19:50:02 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n9AJo2aa004348;
	Sat, 10 Oct 2009 19:50:02 GMT (envelope-from gnats)
Date: Sat, 10 Oct 2009 19:50:02 GMT
Message-Id: <200910101950.n9AJo2aa004348@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Jilles Tjoelker <jilles@stack.nl>
Cc: 
Subject: Re: conf/139040: [patch] 100.clean-disks shouldn't traverse devfs
	mounts
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Jilles Tjoelker <jilles@stack.nl>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Oct 2009 19:50:02 -0000

The following reply was made to PR conf/139040; it has been noted by GNATS.

From: Jilles Tjoelker <jilles@stack.nl>
To: bug-followup@FreeBSD.org, ryand-freebsd@zenspider.com
Cc:  
Subject: Re: conf/139040: [patch] 100.clean-disks shouldn't traverse devfs
	mounts
Date: Sat, 10 Oct 2009 21:42:07 +0200

 Firstly, 8.x/9.x have all the /dev/fd nodes as character devices which
 will not be traversed.
 
 Secondly, your patch will not work. In fact, the entire
   \( ! -fstype local -o -fstype rdonly \) -a -prune
 part prunes nothing at all, since using -delete anywhere implies -d, and
 -prune does nothing if -d is in effect (this is because -d processes
 directories after their contents so -prune is too late). Because of the
 -o after it, it does, however, exclude all files on such filesystems.
 
 It would make more sense to create a list of mount points to traverse,
 then find through them all with -x, somewhat like
 etc/periodic/security/100.chksetuid does.
 
 -- 
 Jilles Tjoelker