From owner-svn-src-head@FreeBSD.ORG Fri Apr 29 14:24:37 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8346E106567B; Fri, 29 Apr 2011 14:24:37 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 54D5F8FC1C; Fri, 29 Apr 2011 14:24:37 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 0185846B59; Fri, 29 Apr 2011 10:24:37 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 6AAE38A02A; Fri, 29 Apr 2011 10:24:36 -0400 (EDT) From: John Baldwin To: Rick Macklem Date: Fri, 29 Apr 2011 10:24:34 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <201104291230.p3TCUFOR099081@svn.freebsd.org> In-Reply-To: <201104291230.p3TCUFOR099081@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201104291024.34096.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Fri, 29 Apr 2011 10:24:36 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221205 - head/sys/fs/nfsclient X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2011 14:24:37 -0000 On Friday, April 29, 2011 8:30:15 am Rick Macklem wrote: > Author: rmacklem > Date: Fri Apr 29 12:30:15 2011 > New Revision: 221205 > URL: http://svn.freebsd.org/changeset/base/221205 > > Log: > The build was broken by r221190 for 64bit arches like amd64. > This patch fixes it. > > MFC after: 2 weeks > > Modified: > head/sys/fs/nfsclient/nfs_clvfsops.c > > Modified: head/sys/fs/nfsclient/nfs_clvfsops.c Somewhat related. It seems the vfs_* API used to process nmount-style mount options, uses 'int' instead of 'size_t' for all of its 'len' parameters. I think this is a bug and that it should be fixed to use size_t instead. That would let this change be reverted as 'len' could always be a size_t in this case. -- John Baldwin