From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Aug 28 16:10:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id CDA3BEF for ; Wed, 28 Aug 2013 16:10:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id AC2CC2487 for ; Wed, 28 Aug 2013 16:10:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r7SGA09d054783 for ; Wed, 28 Aug 2013 16:10:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r7SGA0l6054782; Wed, 28 Aug 2013 16:10:00 GMT (envelope-from gnats) Resent-Date: Wed, 28 Aug 2013 16:10:00 GMT Resent-Message-Id: <201308281610.r7SGA0l6054782@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Boris Samorodov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id CBDADDE3 for ; Wed, 28 Aug 2013 15:59:56 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id AA1CC2388 for ; Wed, 28 Aug 2013 15:59:56 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r7SFxudW077309 for ; Wed, 28 Aug 2013 15:59:56 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r7SFxuqt077308; Wed, 28 Aug 2013 15:59:56 GMT (envelope-from nobody) Message-Id: <201308281559.r7SFxuqt077308@oldred.freebsd.org> Date: Wed, 28 Aug 2013 15:59:56 GMT From: Boris Samorodov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/181622: [patch] misc/digitemp: fix build with clang and some more X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Aug 2013 16:10:00 -0000 >Number: 181622 >Category: ports >Synopsis: [patch] misc/digitemp: fix build with clang and some more >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Wed Aug 28 16:10:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Boris Samorodov >Release: FreeBSD 10.0-CURRENT >Organization: BSDprint >Environment: FreeBSD bsam.int.wart.ru 10.0-CURRENT FreeBSD 10.0-CURRENT #36 r254961: Wed Aug 28 02:04:00 SAMT 2013 bsam@bsam.int.wart.ru:/usr/obj/usr/src/sys/BB64X amd64 >Description: The port does not build with clang: ----- ===> Building for digitemp-3.6.0 gcc -I./src -I./userial -O2 -Wall -DFREEBSD -c -o src/digitemp.o src/digitemp.c gmake: gcc: Command not found gmake: *** [src/digitemp.o] Error 127 ----- >How-To-Repeat: >Fix: . fix build with clang (CC=gcc -> CC?=gcc); . trim makefile headers; . remove LICENSE_FILE for well-known license (GPLv2, anyway it get installed by the ports infrastructure); . optionify port docs (NOPORTDOCS -> PORT_OPTIONS:MDOCS); . use standard mkdir to create directories instead of "install -d"; . some other tiny refinements. Patch attached with submission follows: Index: Makefile =================================================================== --- Makefile (revision 325431) +++ Makefile (working copy) @@ -1,9 +1,5 @@ -# New ports collection makefile for: digitemp -# Date created: 25 June 2011 -# Whom: Evaldas Auryla -# +# Created by: Evaldas Auryla # $FreeBSD$ -# PORTNAME= digitemp PORTVERSION= 3.6.0 @@ -14,19 +10,25 @@ COMMENT= Dallas Semiconductor 1-wire device reading console application LICENSE= GPLv2 -LICENSE_FILE= ${WRKSRC}/COPYRIGHT -USE_GMAKE= yes +USES= gmake MAN1= digitemp.1 PLIST_FILES= bin/digitemp_DS9097 bin/digitemp_DS9097U \ etc/digitemp.conf.sample -PORTDOCS= ChangeLog COPYING COPYRIGHT CREDITS FAQ README TODO \ - dthowto.txt DS9097_Schematic.gif perl python rrdb +DOCFILES= ChangeLog COPYRIGHT CREDITS FAQ README TODO \ + dthowto.txt DS9097_Schematic.gif +DOCDIRS= perl python rrdb +PORTDOCS= ${DOCFILES} ${DOCDIRS} ALL_TARGET= ds9097 ds9097u +OPTIONS_DEFINE= DOCS + +post-patch: + @${REINPLACE_CMD} -e 's:= gcc:?= gcc:' ${WRKSRC}/Makefile + pre-install: ${CP} ${WRKSRC}/${MAN1} ${WRKSRC}/digitemp.1.M ${CAT} ${WRKSRC}/digitemp.1.M | ${SED} -e "s/dev\/ttyS/dev\/cuau/g" > ${WRKSRC}/${MAN1} @@ -36,13 +38,14 @@ ${INSTALL_PROGRAM} ${WRKSRC}/digitemp_DS9097U ${PREFIX}/bin ${INSTALL_MAN} ${WRKSRC}/${MAN1} ${PREFIX}/man/man1 +.include + post-install: -.if !defined(NOPORTDOCS) - ${INSTALL} -d ${DOCSDIR} - @${INSTALL_DATA} ${WRKSRC}/ChangeLog ${WRKSRC}/COPYING ${WRKSRC}/COPYRIGHT ${WRKSRC}/CREDITS ${WRKSRC}/FAQ \ - ${WRKSRC}/README ${WRKSRC}/TODO ${WRKSRC}/dthowto.txt ${WRKSRC}/DS9097_Schematic.gif ${DOCSDIR} +.if ${PORT_OPTIONS:MDOCS} + @${MKDIR} ${DOCSDIR} + ${INSTALL_DATA} ${DOCFILES:S,^,${WRKSRC}/,} ${DOCSDIR} .for dir in perl python/gui python/mysql rrdb - ${INSTALL} -d ${DOCSDIR}/${dir} + @${MKDIR} ${DOCSDIR}/${dir} ${FIND} ${WRKSRC}/${dir}/ -maxdepth 1 -type f -exec ${INSTALL_DATA} \{\} ${DOCSDIR}/${dir} \; .endfor .endif >Release-Note: >Audit-Trail: >Unformatted: