From owner-freebsd-bugs@FreeBSD.ORG Tue Jun 29 17:00:21 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 78CE7106567B for ; Tue, 29 Jun 2010 17:00:21 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 547FE8FC21 for ; Tue, 29 Jun 2010 17:00:21 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o5TH0LIb062093 for ; Tue, 29 Jun 2010 17:00:21 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o5TH0LgK062087; Tue, 29 Jun 2010 17:00:21 GMT (envelope-from gnats) Resent-Date: Tue, 29 Jun 2010 17:00:21 GMT Resent-Message-Id: <201006291700.o5TH0LgK062087@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Joseph S. Atkinson" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 21E66106566C for ; Tue, 29 Jun 2010 16:58:51 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 0F94C8FC0A for ; Tue, 29 Jun 2010 16:58:51 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o5TGwoMO028180 for ; Tue, 29 Jun 2010 16:58:50 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o5TGwoTb028179; Tue, 29 Jun 2010 16:58:50 GMT (envelope-from nobody) Message-Id: <201006291658.o5TGwoTb028179@www.freebsd.org> Date: Tue, 29 Jun 2010 16:58:50 GMT From: "Joseph S. Atkinson" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/148235: Supress noisy, always fail test condition in devel/xdg-utils X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jun 2010 17:00:21 -0000 >Number: 148235 >Category: misc >Synopsis: Supress noisy, always fail test condition in devel/xdg-utils >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jun 29 17:00:20 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Joseph S. Atkinson >Release: >Organization: >Environment: >Description: xdg-screensaver performs a check for `mv -T` to safely move lockfiles to /tmp. FreeBSD does not support the -T switch, which causes mv to complain and spit out a usage example. If an app is run from the console (such as vlc), when calls to xdg-screensaver are made, it spews this error information to the terminal, possibly leading the user to believe the application is attempting to misappropriately move their data. >How-To-Repeat: Run multimedia/vlc from a terminal, opening any video multimedia type. Watch for scary message that the app failed to `mv` something... >Fix: This patch (which should just be inserted into ${FILESDIR}) comments out the offending test condition and replaces it with the `false` command to essentially skip to the else condition without noisy error messages. IMPORTANT: You must remove the .txt extension required by web based pr interface. Patch attached with submission follows: --- ./scripts/xdg-screensaver.orig 2010-06-29 12:36:04.000000000 -0400 +++ ./scripts/xdg-screensaver 2010-06-29 12:37:22.000000000 -0400 @@ -355,7 +355,9 @@ } # Check if we can use "mv -T" -if mv -T ... ... 2>&1 | grep '\.\.\.' > /dev/null ; then +# FreeBSD cannot, so supress scary messages in the terminal +#if mv -T ... ... 2>&1 | grep '\.\.\.' > /dev/null ; then +if false ; then # We can securely move files in /tmp with mv -T DEBUG 1 "mv -T available" MV="mv -T" >Release-Note: >Audit-Trail: >Unformatted: