From owner-cvs-src@FreeBSD.ORG  Fri Jun 25 12:38:27 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7999E16A4CE; Fri, 25 Jun 2004 12:38:27 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 712DB43D49; Fri, 25 Jun 2004 12:38:27 +0000 (GMT)
	(envelope-from kan@FreeBSD.org)
Received: from freefall.freebsd.org (kan@localhost [127.0.0.1])
	i5PCcRfb057896;	Fri, 25 Jun 2004 12:38:27 GMT
	(envelope-from kan@freefall.freebsd.org)
Received: (from kan@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i5PCcRBI057895;
	Fri, 25 Jun 2004 12:38:27 GMT
	(envelope-from kan)
Date: Fri, 25 Jun 2004 12:38:27 +0000
From: Alexander Kabaev <kan@FreeBSD.org>
To: Dag-Erling Sm?rgrav <des@des.no>
Message-ID: <20040625123827.GA55913@freefall.freebsd.org>
References: <200406250154.i5P1sQcp072094@repoman.freebsd.org>
	<xzp659g0ywd.fsf@dwp.des.no> <20040625120329.GB37003@ip.net.ua>
	<xzp1xk325pg.fsf@dwp.des.no>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <xzp1xk325pg.fsf@dwp.des.no>
User-Agent: Mutt/1.4.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Ruslan Ermilov <ru@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libpam/modules/pam_radius pam_radius.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Jun 2004 12:38:27 -0000

On Fri, Jun 25, 2004 at 02:16:27PM +0200, Dag-Erling Sm?rgrav wrote:
> Ruslan Ermilov <ru@FreeBSD.org> writes:
> > On Fri, Jun 25, 2004 at 11:28:50AM +0200, Dag-Erling Sm?rgrav wrote:
> > > Alexander Kabaev <kan@FreeBSD.org> writes:
> > > >   Log:
> > > >   Remove the use of cast as lvalue.
> > > This trades one style bug for another (missing space before *), breaks
> > > the build on 64-bit platforms, and violates maintainership.
> > Ah, so this commit is responsible for a cross-build breakage...
> 
> No, this one currently only breaks Alpha because we apparently don't
> enforce alignment requirements on other platforms.
> 
It definitely worked for amd64 world, which I guess does not have such
strict alignment requirements. I backed out the change and will let 
maintainer to deal with it to his heart desire. Apologies for DES
for intruding on his turf.

I will downgrade WARNS level for this module at the time of GCC 3.4 import
if the warning will still be there by then.

--
Alexander Kabaev