From owner-freebsd-multimedia@freebsd.org Mon Jul 17 19:57:37 2017 Return-Path: Delivered-To: freebsd-multimedia@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3A09BD9F3E2 for ; Mon, 17 Jul 2017 19:57:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 2130E6F4BE for ; Mon, 17 Jul 2017 19:57:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 1D450D9F3E1; Mon, 17 Jul 2017 19:57:37 +0000 (UTC) Delivered-To: multimedia@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1AF74D9F3E0 for ; Mon, 17 Jul 2017 19:57:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ABAB36F4BC for ; Mon, 17 Jul 2017 19:57:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v6HJvarK063308 for ; Mon, 17 Jul 2017 19:57:36 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: [Bug 220785] audio/jack: Add and enable COOKEDMODE option, Use GitHub Date: Mon, 17 Jul 2017 19:57:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: multimedia@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? merge-quarterly? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jul 2017 19:57:37 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220785 --- Comment #11 from Jan Beich --- Comment on attachment 184447 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D184447 patch > +SUB_FILES=3D pkg-message Why? The file doesn't seem to contain any %% macros such e.g., %%PREFIX%%. > +DYNSIMD_CONFIGURE_ENABLE=3Ddynsimd >=20 > CFLAGS+=3D -I${BDB_INCLUDE_DIR} > +COOKEDMODE_CFLAGS+=3D -DOPTION_COOKEDMODE=3D1 > LIBS+=3D -L${BDB_LIB_DIR} > INSTALL_TARGET=3D install-strip - Rename DYNSIMD to RTCPU which already has default description vi Mk/bsd.options.desc.mk - Don't mix option helpers and generic definitions/flags. It's confusing and breaks existing style in the file. For one, see how other _CONFIGURE_ENABLE= are grouped. - Maybe replace +=3D with plain =3D as _CFLAGS helper already appends (not overrides) the value > +OPTIONS_DEFINE=3D ALSA DOXYGEN READLINE SNDIO COOKEDMODE > +OPTIONS_DEFINE_i386=3D ALSA DOXYGEN READLINE SNDIO COOKEDMODE DYNSIMD > +OPTIONS_DEFINE_amd64=3D ALSA DOXYGEN READLINE SNDIO COOKEDMODE DYNSIMD > +OPTIONS_DEFAULT=3D READLINE COOKEDMODE > +OPTIONS_DEFAULT_i386=3D READLINE COOKEDMODE DYNSIMD > +OPTIONS_DEFAULT_amd64=3D READLINE COOKEDMODE DYNSIMD Can you deduplicate OPTIONS_*_${ARCH} ? Mk/bsd.options.mk already appends (= not overrides) arch-specific options. --=20 You are receiving this mail because: You are the assignee for the bug.=