From owner-freebsd-current@FreeBSD.ORG Sun Dec 14 11:38:59 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BBE2016A4CE; Sun, 14 Dec 2003 11:38:59 -0800 (PST) Received: from mail-gw1.york.ac.uk (mail-gw1.york.ac.uk [144.32.128.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 58DB143D31; Sun, 14 Dec 2003 11:38:57 -0800 (PST) (envelope-from gavin+freebsdc@ury.york.ac.uk) Received: from ury.york.ac.uk (ury.york.ac.uk [144.32.108.81]) by mail-gw1.york.ac.uk (8.12.10/8.12.10) with ESMTP id hBEJcrwq021706; Sun, 14 Dec 2003 19:38:53 GMT Received: from ury.york.ac.uk (localhost.york.ac.uk [127.0.0.1]) by ury.york.ac.uk (8.12.9p2/8.12.9) with ESMTP id hBEJcrcH034740; Sun, 14 Dec 2003 19:38:53 GMT (envelope-from gavin+freebsdc@ury.york.ac.uk) Received: from localhost (gavin@localhost)hBEJcrh0034737; Sun, 14 Dec 2003 19:38:53 GMT (envelope-from gavin+freebsdc@ury.york.ac.uk) Date: Sun, 14 Dec 2003 19:38:53 +0000 (GMT) From: Gavin Atkinson X-X-Sender: gavin@ury.york.ac.uk To: Don Lewis In-Reply-To: <200312072153.hB7LrfTi004032@repoman.freebsd.org> Message-ID: <20031214180746.Y23299@ury.york.ac.uk> References: <200312072153.hB7LrfTi004032@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-York-MailScanner: Found to be clean cc: current@freebsd.org Subject: Re: cvs commit: src/sys/kern subr_mbpool.c subr_mbuf.c X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Dec 2003 19:38:59 -0000 On Sun, 7 Dec 2003, Don Lewis wrote: > truckman 2003/12/07 13:53:41 PST > > Modified files: > sys/kern subr_mbpool.c subr_mbuf.c > Log: > Pass MTX_DEF as the last argument to mtx_init() instead of 0. This > is not a functional change. The code happened to work properly only > because MTX_DEF is defined as 0. Can I also offer the following patches which do the same to other parts of the tree? I believe these patches close the last places where mtx_init is passed incorrect arguments. They have survived a kernel build. http://www.devrandom.co.uk/freebsd/ata-mtx.diff http://www.devrandom.co.uk/freebsd/ng_uni-mtx.diff http://www.devrandom.co.uk/freebsd/pst-mtx.diff (sos cc'd due to ATA patches) Gavin