From nobody Wed Aug 17 16:04:08 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M7CWF5FNsz4Zn04; Wed, 17 Aug 2022 16:04:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M7CWF4jF5z3fd1; Wed, 17 Aug 2022 16:04:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660752249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=egrTe0CV37QouD8Ye9eBGGHC3VFkYqpHu+w257SwwCs=; b=UEGGaZyMQN6kD2KCnctuMCuX3SrwWSeJ0soz9QR2gV+79mbbKxqOIKFnyQXANSyZuUzjH8 1/1Xjr5hCtNBgAKA49jUlf1m49BPODSiXaHtUJpaObHA0TS8vYLyrH3xaI3/EW2RWfW9VK 8pEAWEi6kXmZE8qEDFLSf1ttg9/dhyTx+jvQ4rzgvPvFBX8sTw/2ySHdRKpPbOE9nOT0IN cS9Tu4qg+nIHLWKmxsFGBY2MRsxv/wuT45fBjVoNHVSghSy0393q8v5tr71oV/mwsmchrm n3DlGKz05lVQd8Mqsp6Brh/NhhxGg6ybvzuKiyD5DYbXq12JG71NpSgPjx3fTw== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4M7CWF0j5bz1Qts; Wed, 17 Aug 2022 16:04:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <62dca1e0-8d66-6291-149e-5785af0e2658@FreeBSD.org> Date: Wed, 17 Aug 2022 09:04:08 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Gleb Smirnoff , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202208161940.27GJercD039480@gitrepo.freebsd.org> From: John Baldwin Subject: Re: git: c93db4abf454 - main - udp: call UDP methods from UDP over IPv6 directly In-Reply-To: <202208161940.27GJercD039480@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660752249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=egrTe0CV37QouD8Ye9eBGGHC3VFkYqpHu+w257SwwCs=; b=t0klgZEXX7THccnNxSNxvoxnV6diKGZh+QiXJhUfyFg9ldHX2BT7z2u2D2ISTTU8hLMOHt QzI46Fc2hXC5V9UWaPMVqzyw47N0pWePoO2x9Zx/kTddntG99JR5ChcCLQWRG8UxgAh5Yy SN2tX/YI+O3rm/g9E3C6J0w8gQZG1ZlPJwuf9YhaHmVmSoGcy09ka2gf9wsWONw6TwM05z 20L5xKH6fTQrnXU3M9ObszIwVtkJhRLq8LFc0fpCh+JXojM3bU5rounQ29Xszro34waw7a 6RnsqlRBOnDr6od9/u0b5QGjIcWDVXxGzv7U/AK7TFo6dQvVS5jS9Zb7DJDTTQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1660752249; a=rsa-sha256; cv=none; b=dbIefUx66K4owQsvEYCYSjzAPxLyaegcfZ9A6RfavIGGo43QIcQK3H+VsQfdieX0Clb7fX afjd/EVecfoiVvmDlWtofxr0ygQ+CDNVeAJpMuaAYM+YI+8oOQAE8+zFa/NRdacTw57dn8 8tgSF8jh2HvQ7rmMwAdJOMuHlU/cBvhLIY707GIXS9A8g88l4bJMzDMolMPgbTjtLsjhXD Diac3zBgyJwk3nnNJfbdI0gUe0tvar1wqm+32e7rT9XNRTfvjDqy3lEonnJFR6rgZHn4AA U1wQJLcpJrIFXd8MJfjNhUWz0KzIdHRAEvd8AqlHFBIVy+OkqGmDapevzpLINw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 8/16/22 12:40 PM, Gleb Smirnoff wrote: > The branch main has been updated by glebius: > > URL: https://cgit.FreeBSD.org/src/commit/?id=c93db4abf4545d1bc8cb2b67eacd17f6d1ee6b74 > > commit c93db4abf4545d1bc8cb2b67eacd17f6d1ee6b74 > Author: Gleb Smirnoff > AuthorDate: 2022-08-16 19:40:36 +0000 > Commit: Gleb Smirnoff > CommitDate: 2022-08-16 19:40:36 +0000 > > udp: call UDP methods from UDP over IPv6 directly > > Both UDP and UDP Lite use same methods on sockets. Both UDP over IPv4 > and over IPv6 use same methods. Don't pretend that methods can switch > and remove this unneeded complexity. > > Reviewed by: melifaro > Differential revision: https://reviews.freebsd.org/D36154 > --- > sys/netinet/udp_usrreq.c | 9 ++++++--- > sys/netinet6/udp6_usrreq.c | 37 +++++++++++-------------------------- > 2 files changed, 17 insertions(+), 29 deletions(-) > > diff --git a/sys/netinet6/udp6_usrreq.c b/sys/netinet6/udp6_usrreq.c > index a7bdfce97707..6a3ac2abd90b 100644 > --- a/sys/netinet6/udp6_usrreq.c > +++ b/sys/netinet6/udp6_usrreq.c > @@ -131,12 +131,18 @@ VNET_DEFINE(int, zero_checksum_port) = 0; > SYSCTL_INT(_net_inet6_udp6, OID_AUTO, rfc6935_port, CTLFLAG_VNET | CTLFLAG_RW, > &VNET_NAME(zero_checksum_port), 0, > "Zero UDP checksum allowed for traffic to/from this port."); > + > + > +/* netinet/udp_usrreqs.c */ > +pr_abort_t udp_abort; > +pr_disconnect_t udp_disconnect; > +pr_send_t udp_send; > + Oof, can you please put these in a header instead? would seem to be a good candidate. -- John Baldwin