From owner-cvs-all@FreeBSD.ORG  Wed Sep 29 14:03:42 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3019C16A4CF; Wed, 29 Sep 2004 14:03:42 +0000 (GMT)
Received: from harmony.village.org (rover.village.org [168.103.84.182])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 60CCB43D1D; Wed, 29 Sep 2004 14:03:41 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (harmony.village.org [10.0.0.6])
	by harmony.village.org (8.13.1/8.13.1) with ESMTP id i8TE1LeJ014294;
	Wed, 29 Sep 2004 08:01:21 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Wed, 29 Sep 2004 08:02:38 -0600 (MDT)
Message-Id: <20040929.080238.02184004.imp@bsdimp.com>
To: phk@phk.freebsd.dk
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <19681.1096444779@critter.freebsd.dk>
References: <20040929074552.GA909@freebsd3.cimlogic.com.au>
	<19681.1096444779@critter.freebsd.dk>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: jb@cimlogic.com.au
Subject: Re: cvs commit: src/sys/dev/fdc fdc_isa.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Sep 2004 14:03:42 -0000

In message: <19681.1096444779@critter.freebsd.dk>
            "Poul-Henning Kamp" <phk@phk.freebsd.dk> writes:
: (BTW, Warner:  Shouldn't this:
: 
: 	static u_int8_t
: 	fdsts_rd(struct fdc_data *fdc)
: 	{
: 		
: 		return bus_space_read_1(fdc->portt, fdc->porth, FDSTS+fdc->port_off);
: 	}
: 
: be changed to:
: 
: 	static u_int8_t
: 	fdsts_rd(struct fdc_data *fdc)
: 	{
: 		
: 		return bus_space_read_1(fdc->stst, fdc->stsh, FDSTS+fdc->sts_off);
: 	}
: 
: )

Yes.  I think it should.  I think that it won't matter at all in
actual fact, but is pedantically incorrect.

Warner