From owner-dev-commits-src-all@freebsd.org Wed Jan 20 08:31:55 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E73784EE47B; Wed, 20 Jan 2021 08:31:55 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DLJfL6VmTz3t7c; Wed, 20 Jan 2021 08:31:54 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pj1-x1033.google.com with SMTP id l23so1761169pjg.1; Wed, 20 Jan 2021 00:31:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=uiEulb/uccQD7sLqwgfwsRnCJVquzEUSECqFG1e4Jyg=; b=Djz/2AWZmCS6pG1msy1rTTG23fkVDeTJ+ykn4BbTD544EQ+srQIWOg2qSGDmzH0yqC 1ncJ3WljWEOeMBii7w90iM4vvI6nYgU6/57S7QYXps5qmN+8y+o2hq6Nk4hCYqREx2Ls dowfEGl9ualrInDOyUsXM355znEE7iK8i5xIGIBC8y2OoYvPEVsSKcCqF4T3W11snfZ4 ePKQZ2uNSj5o2RMy1PLJd2rzNsru+WS0V/8RRteBxJMkEd2kKEZL0E1lRpaA1omH3Ysz 0WPVmubHjtzqdlof1yRqFiAWCRIOar6U6+kbYcuKGBzXYljerb+VmInge3c/DtJPkeUb 86OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=uiEulb/uccQD7sLqwgfwsRnCJVquzEUSECqFG1e4Jyg=; b=AHpBI4TlEh/5dzhzxRYjk5DHCli5KTxwjHiF/Sud84QmO1jF6MuFYW1coJrAfcwCwp AFuyRCc+m2IZaFk2szpi6OfQshYON8zUrwVsK2S815p2nCEeHSme8Eq24TKuo1PEQ2HS Y6QiiMIaPvMe0gmAlbptfvvqm2tcSQxXdLpJOFA4PL32pl0LEaKXngnkVp98XKbY6x0s DxrINGommVW+Ri4XcJ4TB2dKByhb4GPdYqhy80o1ba+kTN7aJ0h7vA7SNrU5bgoTbYpd 1sTgwOaXcKNAbRmTe/rvsqHTZPcnPETXhpmOe+A78O1GUiu3joxxNdPpBurskSIGA//z gLvA== X-Gm-Message-State: AOAM533iJQRcDoOJ4NN0xQdnQTGCXGNWP1XChZzl/4Wnwwi88qp9D81b U0Y+TV0UVKWphse4yZHsrI8oiaBOogsLZw== X-Google-Smtp-Source: ABdhPJzGvRa5jSmZduF69CeDmFZ2cBAQsaeuSYBXOaQEiGx7rmgPjfqyLtfY0jRDjjWRyVrrLIG9jA== X-Received: by 2002:a17:902:b904:b029:dc:18f2:9419 with SMTP id bf4-20020a170902b904b02900dc18f29419mr8751309plb.66.1611131513198; Wed, 20 Jan 2021 00:31:53 -0800 (PST) Received: from [192.168.20.29] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id n2sm1475949pfu.129.2021.01.20.00.31.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jan 2021 00:31:52 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: git: e83b514a9563 - main - cat: depend on Makefile to rebuild when WITH_CASPER changes From: Enji Cooper In-Reply-To: <202101171722.10HHMQwh098665@gitrepo.freebsd.org> Date: Wed, 20 Jan 2021 00:31:50 -0800 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202101171722.10HHMQwh098665@gitrepo.freebsd.org> To: Ed Maste X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4DLJfL6VmTz3t7c X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Djz/2AWZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::1033 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-1.51 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::1033:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RECEIVED_SPAMHAUS_PBL(0.00)[73.19.52.228:received]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; NEURAL_SPAM_SHORT(0.99)[0.994]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::1033:from:127.0.2.255]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::1033:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[dev-commits-src-all,dev-commits-src-main] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2021 08:31:56 -0000 > On Jan 17, 2021, at 9:22 AM, Ed Maste wrote: >=20 > The branch main has been updated by emaste: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3De83b514a9563d5812c9d158ff976f0de= 96bd90e0 >=20 > commit e83b514a9563d5812c9d158ff976f0de96bd90e0 > Author: Ed Maste > AuthorDate: 2021-01-17 17:15:40 +0000 > Commit: Ed Maste > CommitDate: 2021-01-17 17:19:00 +0000 >=20 > cat: depend on Makefile to rebuild when WITH_CASPER changes >=20 > We try to ensure building WITHOUT_CLEAN (or -DNO_CLEAN) works on an > ongoing basis. b7ab6832cd98 changed cat to build w/o -DWITH_CASPER > by default; add a cat.o dependency on the Makefile so that it gets > rebuilt. > --- > bin/cat/Makefile | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/bin/cat/Makefile b/bin/cat/Makefile > index cce69d8aad9e..06bb071363f8 100644 > --- a/bin/cat/Makefile > +++ b/bin/cat/Makefile > @@ -22,5 +22,7 @@ SUBDIR.${MK_TESTS}+=3D tests > #LIBADD+=3D cap_net > #CFLAGS+=3D-DWITH_CASPER > #.endif > +# Depend on Makefile to rebiuld when WITH_CASPER changes > +cat.o: Makefile Hi Ed, Could this maybe use ${MAKEFILE} or .MAKE.MAKEFILES, e.g., = ${.MAKE.MAKEFILES:[0]}, instead? IIRC meta mode might take care of this automatically, but bdrewery could = answer this definitively. Cheers! -Enji=