Date: Wed, 20 Jan 2021 00:31:50 -0800 From: Enji Cooper <yaneurabeya@gmail.com> To: Ed Maste <emaste@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: e83b514a9563 - main - cat: depend on Makefile to rebuild when WITH_CASPER changes Message-ID: <F5B381F3-1E0E-4A32-8CBA-C42E766189EC@gmail.com> In-Reply-To: <202101171722.10HHMQwh098665@gitrepo.freebsd.org> References: <202101171722.10HHMQwh098665@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jan 17, 2021, at 9:22 AM, Ed Maste <emaste@freebsd.org> wrote: >=20 > The branch main has been updated by emaste: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3De83b514a9563d5812c9d158ff976f0de= 96bd90e0 >=20 > commit e83b514a9563d5812c9d158ff976f0de96bd90e0 > Author: Ed Maste <emaste@FreeBSD.org> > AuthorDate: 2021-01-17 17:15:40 +0000 > Commit: Ed Maste <emaste@FreeBSD.org> > CommitDate: 2021-01-17 17:19:00 +0000 >=20 > cat: depend on Makefile to rebuild when WITH_CASPER changes >=20 > We try to ensure building WITHOUT_CLEAN (or -DNO_CLEAN) works on an > ongoing basis. b7ab6832cd98 changed cat to build w/o -DWITH_CASPER > by default; add a cat.o dependency on the Makefile so that it gets > rebuilt. > --- > bin/cat/Makefile | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/bin/cat/Makefile b/bin/cat/Makefile > index cce69d8aad9e..06bb071363f8 100644 > --- a/bin/cat/Makefile > +++ b/bin/cat/Makefile > @@ -22,5 +22,7 @@ SUBDIR.${MK_TESTS}+=3D tests > #LIBADD+=3D cap_net > #CFLAGS+=3D-DWITH_CASPER > #.endif > +# Depend on Makefile to rebiuld when WITH_CASPER changes > +cat.o: Makefile Hi Ed, Could this maybe use ${MAKEFILE} or .MAKE.MAKEFILES, e.g., = ${.MAKE.MAKEFILES:[0]}, instead? IIRC meta mode might take care of this automatically, but bdrewery could = answer this definitively. Cheers! -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F5B381F3-1E0E-4A32-8CBA-C42E766189EC>