From owner-svn-src-all@FreeBSD.ORG  Tue Aug 26 13:49:49 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id CB3865C8;
 Tue, 26 Aug 2014 13:49:49 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A275338B4;
 Tue, 26 Aug 2014 13:49:49 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id C7DCBB95E;
 Tue, 26 Aug 2014 09:49:47 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Mateusz Guzik <mjg@freebsd.org>
Subject: Re: svn commit: r270648 - in head/sys: kern sys
Date: Tue, 26 Aug 2014 09:45:38 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20140415; KDE/4.5.5; amd64; ; )
References: <201408260817.s7Q8HMMT044455@svn.freebsd.org>
In-Reply-To: <201408260817.s7Q8HMMT044455@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201408260945.39017.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Tue, 26 Aug 2014 09:49:47 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Aug 2014 13:49:49 -0000

On Tuesday, August 26, 2014 4:17:22 am Mateusz Guzik wrote:
> Author: mjg
> Date: Tue Aug 26 08:17:22 2014
> New Revision: 270648
> URL: http://svnweb.freebsd.org/changeset/base/270648
> 
> Log:
>   Fix up races with f_seqcount handling.
>   
>   It was possible that the kernel would overwrite user-supplied hint.
>   
>   Abuse vnode lock for this purpose.
>   
>   In collaboration with: kib
>   MFC after:	1 week

Do we care about this being correct enough to penalize reads by single-
threading them?  This is just an optimization, if you lose the race it doesn't 
actually break anything.

-- 
John Baldwin