From owner-freebsd-bugs@FreeBSD.ORG  Fri May 14 12:40:06 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F275D1065674
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 14 May 2010 12:40:06 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (unknown [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id C9A948FC0C
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 14 May 2010 12:40:06 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o4ECe6sX068781
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 14 May 2010 12:40:06 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o4ECe6Xb068778;
	Fri, 14 May 2010 12:40:06 GMT (envelope-from gnats)
Date: Fri, 14 May 2010 12:40:06 GMT
Message-Id: <201005141240.o4ECe6Xb068778@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: bin/146189: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 May 2010 12:40:07 -0000

The following reply was made to PR bin/146189; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/146189: commit references a PR
Date: Fri, 14 May 2010 12:34:16 +0000 (UTC)

 Author: ed
 Date: Fri May 14 12:34:06 2010
 New Revision: 208070
 URL: http://svn.freebsd.org/changeset/base/208070
 
 Log:
   MFC r207453:
   
     Remove WNOHANG flag from wait3().
   
     Because script(1) now reliably terminates when the TTY is closed, it may
     be the case that the call to wait3() occurs just before the child
     process exits. This causes error codes to be ignored.
   
     Just change script(1) to use waitpid() instead of wait3(). This makes it
     more portable and prevents the need for a loop, since waitpid() only
     returns a specified process.
   
   PR:           bin/146189
   Tested by:    amdmi3@, older version
 
 Modified:
   stable/8/usr.bin/script/script.c
 Directory Properties:
   stable/8/usr.bin/script/   (props changed)
 
 Modified: stable/8/usr.bin/script/script.c
 ==============================================================================
 --- stable/8/usr.bin/script/script.c	Fri May 14 10:06:20 2010	(r208069)
 +++ stable/8/usr.bin/script/script.c	Fri May 14 12:34:06 2010	(r208070)
 @@ -219,23 +219,17 @@ usage(void)
  void
  finish(void)
  {
 -	pid_t pid;
 -	int die, e, status;
 +	int e, status;
  
 -	die = e = 0;
 -	while ((pid = wait3(&status, WNOHANG, 0)) > 0)
 -	        if (pid == child) {
 -			die = 1;
 -			if (WIFEXITED(status))
 -				e = WEXITSTATUS(status);
 -			else if (WIFSIGNALED(status))
 -				e = WTERMSIG(status);
 -			else /* can't happen */
 -				e = 1;
 -		}
 -
 -	if (die)
 +	if (waitpid(child, &status, 0) == child) {
 +		if (WIFEXITED(status))
 +			e = WEXITSTATUS(status);
 +		else if (WIFSIGNALED(status))
 +			e = WTERMSIG(status);
 +		else /* can't happen */
 +			e = 1;
  		done(e);
 +	}
  }
  
  void
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"