From nobody Tue Apr 28 20:52:16 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g4t0c5ssMz6c57M for ; Tue, 28 Apr 2026 20:52:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g4t0c44Jnz3N8j for ; Tue, 28 Apr 2026 20:52:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777409536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XSW3/y6JFuOnRyn/22pTxwDM8AFqxA31Fh+hf3G5V18=; b=CrsG6za1Dvsl5jYl4Zh6KWOx3CbaKtEDs6KGczvmkD3+XsImlAITaR4TqYfbuhpjCloveG PSruhdwZDlfqCwDdsw50tu5mO6a/oUK6ctrZrwK2NYotjURY58sJEe1QXOX2rQGTeVHAvg WViDNR9BeLM/5gCtDr09/UA8d/Gk5P2NdgLO8okjP8MABmfX9mjD4UWN8Wcfjr66MmtcfK 6DXoGIj3RawJ6SwTy5Qh7Dlfk5MUal7CStU93hKyD92U73cqdyKwFi+06g8npq2j3pvBoC lM8cmugr7gmXD/z0pZaUSQuSB+yKe+0gB5dOCzlIC8wnaJYaX5Octy2qm8qXmA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777409536; a=rsa-sha256; cv=none; b=dUoO0obrR384CuR2J227JsRMPeOBuoe/VSW36vmaYFfWPoJuiJnnLixSHKKw5kjKnQDG8g d5ia7YAjyu7TirPXLtbhmH158Nz7XMaB9TCqnA95k2BIVbnGFzgaov6ZE62dkgqYGkNtY3 f/XAxpqaGy2VcC+bbmF2JbWMXuIMlew+OUwtQDQ9JP/6rPfd2DbV/iQnp9aO9zcmrs2Pj3 YIVDGEtFpxLFjVBpXqZUuNrZ6/YPA/O79lbJy+DoN8q4PE3zG3L76EMmp9na8exTKElLum SFbLt6GdpYK22KK2k84m1AO5ggSzPZrgF3dePZ2d8/QJVVXn8EiltGXClkaJ9Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777409536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XSW3/y6JFuOnRyn/22pTxwDM8AFqxA31Fh+hf3G5V18=; b=dEPHF8tWbzJbWiGTXJpqm4WTrEI7psY+5E1/V31R4ra5ho6RNsk4epAZh/+1xtds83RSuB bE0Hbx+Ur4b9qW0W8aYtkik3DdyJJ+vJylEyNrS4zmjVOgzbulempotix2JRrV51v/mNcv DgE9He89V1Mne7pqD4PhWYY48DoG4Wv62x17ZedB7vphXpFjuguk6nIjnZ0m679Tf6ZCxi 8oLCrOr/BR352ydxyk7yVeSTBFbXtofVx64yNsHITjngklag0cuzXkybZUTpMIx6C1MTlY 9IZF15O9a/nTTuL7vEZUv58iTjcucsEHg7d/7Byi7CIoDI98ZY1dwLw5C42lmg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g4t0c3VQ2z18pY for ; Tue, 28 Apr 2026 20:52:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3aee4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 28 Apr 2026 20:52:16 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: fe9d81d7c660 - main - libiscsiutil: preserve errno across warning logs List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fe9d81d7c6602e9b18cde2aaf8cbd5f65b87c091 Auto-Submitted: auto-generated Date: Tue, 28 Apr 2026 20:52:16 +0000 Message-Id: <69f11e00.3aee4.13ab5446@gitrepo.freebsd.org> The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=fe9d81d7c6602e9b18cde2aaf8cbd5f65b87c091 commit fe9d81d7c6602e9b18cde2aaf8cbd5f65b87c091 Author: Kyle Evans AuthorDate: 2026-04-28 20:51:50 +0000 Commit: Kyle Evans CommitDate: 2026-04-28 20:51:50 +0000 libiscsiutil: preserve errno across warning logs Various calls in the implementation can clobber errno; preserve it for the caller since none of these will bubble up pass/fail to simplify some future error handling in ctld. Reviewed by: jhb Differential Revision: https://reviews.freebsd.org/D56539 --- lib/libiscsiutil/log.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/libiscsiutil/log.c b/lib/libiscsiutil/log.c index cead4ab2d709..a48a96a7d47a 100644 --- a/lib/libiscsiutil/log.c +++ b/lib/libiscsiutil/log.c @@ -86,7 +86,7 @@ log_common(int priority, int log_errno, const char *fmt, va_list ap) static char msgbuf[MSGBUF_LEN]; static char msgbuf_strvised[MSGBUF_LEN * 4 + 1]; char *errstr; - int ret; + int ret, serrno = errno; ret = vsnprintf(msgbuf, sizeof(msgbuf), fmt, ap); if (ret < 0) { @@ -138,6 +138,8 @@ log_common(int priority, int log_errno, const char *fmt, va_list ap) msgbuf_strvised, errstr); } } + + errno = serrno; } void