Date: Mon, 24 Feb 2014 15:40:30 +0000 (UTC) From: Mathieu Arnold <mat@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r345870 - head/Mk Message-ID: <201402241540.s1OFeUPA085356@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mat Date: Mon Feb 24 15:40:30 2014 New Revision: 345870 URL: http://svnweb.freebsd.org/changeset/ports/345870 QAT: https://qat.redports.org/buildarchive/r345870/ Log: Really tell our users that using WITH_/WITHOUT_ to set/unset options is deprecated. Sponsored by: Absolight Modified: head/Mk/bsd.options.mk Modified: head/Mk/bsd.options.mk ============================================================================== --- head/Mk/bsd.options.mk Mon Feb 24 15:31:14 2014 (r345869) +++ head/Mk/bsd.options.mk Mon Feb 24 15:40:30 2014 (r345870) @@ -259,13 +259,39 @@ NEW_OPTIONS:= ${NEW_OPTIONS:N${opt}} ### convert WITH and WITHOUT found in make.conf or reloaded from old optionsfile .for opt in ${ALL_OPTIONS} .if defined(WITH_${opt}) +OPTIONS_WARNINGS+= "WITH_${opt}" +OPTIONS_WARNINGS_SET+= ${opt} PORT_OPTIONS+= ${opt} .endif .if defined(WITHOUT_${opt}) +OPTIONS_WARNINGS+= "WITHOUT_${opt}" +OPTIONS_WARNINGS_UNSET+= ${opt} PORT_OPTIONS:= ${PORT_OPTIONS:N${opt}} .endif .endfor +.if defined(OPTIONS_WARNINGS) +WARNING+= "You are using the following deprecated options: ${OPTIONS_WARNINGS}" +WARNING+= "If you added them on the command line, you should replace them by" +WARNING+= "WITH=\"${OPTIONS_WARNINGS_SET}\" WITHOUT=\"${OPTIONS_WARNINGS_UNSET}\"" +WARNING+= "" +WARNING+= "If they are global options set in your make.conf, you should replace them with:" +.if defined(OPTIONS_WARNINGS_SET) +WARNING+= "OPTIONS_SET=${OPTIONS_WARNINGS_SET}" +.endif +.if defined(OPTIONS_WARNINGS_UNSET) +WARNING+= "OPTIONS_UNSET=${OPTIONS_WARNINGS_UNSET}" +.endif +WARNING+= "" +WARNING+= "If they are local to this port, you should use:" +.if defined(OPTIONS_WARNINGS_SET) +WARNING+= "${OPTIONS_NAME}_SET=${OPTIONS_WARNINGS_SET}" +.endif +.if defined(OPTIONS_WARNINGS_UNSET) +WARNING+= "${OPTIONS_NAME}_UNSET=${OPTIONS_WARNINGS_UNSET}" +.endif +.endif + ## Finish by using the options set by the port config dialog, if any . for opt in ${OPTIONS_FILE_SET} . if !empty(COMPLETE_OPTIONS_LIST:M${opt})
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402241540.s1OFeUPA085356>