From owner-svn-ports-head@FreeBSD.ORG Mon Jun 3 23:14:44 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id DFB61788; Mon, 3 Jun 2013 23:14:44 +0000 (UTC) (envelope-from trhodes@FreeBSD.org) Received: from homiemail-a73.g.dreamhost.com (caiajhbdcahe.dreamhost.com [208.97.132.74]) by mx1.freebsd.org (Postfix) with ESMTP id C227E1DBA; Mon, 3 Jun 2013 23:14:43 +0000 (UTC) Received: from homiemail-a73.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a73.g.dreamhost.com (Postfix) with ESMTP id 152CA1F01A3; Mon, 3 Jun 2013 16:14:43 -0700 (PDT) Received: from lab (ip72-219-240-45.dc.dc.cox.net [72.219.240.45]) (Authenticated sender: trhodes@fbsdsecure.org) by homiemail-a73.g.dreamhost.com (Postfix) with ESMTPA id 3E8361F08FD; Mon, 3 Jun 2013 15:04:15 -0700 (PDT) Date: Mon, 3 Jun 2013 18:04:13 -0400 From: Tom Rhodes To: Baptiste Daroussin Subject: Re: svn commit: r319792 - head/sysutils/fsc Message-Id: <20130603180413.7fbe7366.trhodes@FreeBSD.org> In-Reply-To: <20130603201831.GO12427@ithaqua.etoilebsd.net> References: <201306031632.r53GWPdP069628@svn.freebsd.org> <51ACC994.4060608@FreeBSD.org> <20130603133012.114c2ae7.trhodes@FreeBSD.org> <51ACDC95.4060600@FreeBSD.org> <20130603155106.7f3e5826.trhodes@FreeBSD.org> <20130603201831.GO12427@ithaqua.etoilebsd.net> X-Mailer: Sylpheed version 1.0.6 (GTK+ 1.2.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, bdrewery@FreeBSD.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2013 23:14:45 -0000 On Mon, 3 Jun 2013 22:18:31 +0200 Baptiste Daroussin wrote: > On Mon, Jun 03, 2013 at 03:51:06PM -0400, Tom Rhodes wrote: > > On Mon, 03 Jun 2013 13:12:37 -0500 > > Bryan Drewery wrote: > > > > > On 6/3/2013 12:30 PM, Tom Rhodes wrote: > > > > On Mon, 03 Jun 2013 11:51:32 -0500 > > > > Bryan Drewery wrote: > > > > > > > >> This is bad form. If you are changing upstream code it should be a new > > > >> release version, not a reroll. We frequently have problems with other > > > >> upstreams doing this and should follow our own guidelines. > > > > > > > > I'm not bumping the version used for a simple gcc->clang warning > > > > fix. That's why I just bumped PORTVERSION. If we want to do a > > > > new version, I'll get ahold of the NetBSD people, who also work > > > > with keeping a port, and discuss doing that. In this case, it > > > > was a simple fix rather than adding a 2 line patch to a files/ > > > > directory. > > > > > > > > > > The proper way to do is this a new release, or a patch in files with a > > > PORTREVISION, or a sed in post-patch. This is the convention. Rerolling > > > upstream is a big no no. Rerolling is obscure and very frowned upon. > > > This also impacts NetBSD if they are tracking checksums, and any other > > > projects depending on the checksum of the upstream tarball. > > > > I'll look at bumping the release version - there are some other > > changes that need made anyway, I just wanted to fix the build so > > users could build it again. > > In that case a patch in files/ is the way to go. I think the changes are a version bump - I'm working with some NetBSD people on this, so I'll discuss with them. > > > > > > > > If you had a ports committer approve/review this change, which you > > > should have and should do in the future, this would have been avoided. > > > > I am a ports committer, sorry I forgot about this - considering I > > commit to this area rarely. So you can remind me about the rule, > > link to relevant documention, and I will remember for the future > > or "fix" the issue. No attitude needed. > > According the following: > http://svnweb.freebsd.org/ports?view=revision&revision=182927 > > You removed yourself your commit bit 6 years ago. That's right, so my statement should have been, properly: "At one point, I was a ports committer ..." ;) -- Tom Rhodes