From owner-svn-ports-head@freebsd.org Tue Apr 18 16:30:33 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 25002D438A9; Tue, 18 Apr 2017 16:30:33 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (prod2.absolight.net [79.143.243.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id DCCCFE18; Tue, 18 Apr 2017 16:30:32 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id B2935BDC89; Tue, 18 Apr 2017 18:30:29 +0200 (CEST) Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by prod2.absolight.net (Postfix) with ESMTPSA id 83AE2BDC85; Tue, 18 Apr 2017 18:30:29 +0200 (CEST) Subject: Re: svn commit: r438739 - head/editors/emacs-devel To: Joseph Mingrone , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201704171817.v3HIHrKH039517@repo.freebsd.org> From: Mathieu Arnold Organization: Absolight / The FreeBSD Foundation Message-ID: <9c424b79-d270-6d5f-c625-3de54e721888@FreeBSD.org> Date: Tue, 18 Apr 2017 18:30:27 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <201704171817.v3HIHrKH039517@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wwrWGQD8DeJNIjlAVhEBPpMl4tmOAwMwD" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2017 16:30:33 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wwrWGQD8DeJNIjlAVhEBPpMl4tmOAwMwD Content-Type: multipart/mixed; boundary="ShJ1lCjtkGtFxeK9ExpdcD958dJ7OOF9w"; protected-headers="v1" From: Mathieu Arnold To: Joseph Mingrone , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <9c424b79-d270-6d5f-c625-3de54e721888@FreeBSD.org> Subject: Re: svn commit: r438739 - head/editors/emacs-devel References: <201704171817.v3HIHrKH039517@repo.freebsd.org> In-Reply-To: <201704171817.v3HIHrKH039517@repo.freebsd.org> --ShJ1lCjtkGtFxeK9ExpdcD958dJ7OOF9w Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: fr Le 17/04/2017 =C3=A0 20:17, Joseph Mingrone a =C3=A9crit : > Also add MAKE_JOBS_UNSAFE=3Dyes. > =20 This bit of the commit message is useless. The fact that you added MAKE_JOBS_UNSAFE can be seen clearly in the commit diff below. What cannot be seen and is now lost is why you are adding it. Does it have problems ordering targets ? Does it try to use a file before it is generated... ? People regularly go and try to fix these kind of things. If you do not explain they why, it is lost, and they have no idea where to begin their search. --=20 Mathieu Arnold --ShJ1lCjtkGtFxeK9ExpdcD958dJ7OOF9w-- --wwrWGQD8DeJNIjlAVhEBPpMl4tmOAwMwD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJY9j8kXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IfvUP/RpzUXI4W+dykyEY0MWsJPVF TL0e6Ne7AE6D2l9qgOzOhMkQA45lqd3xtYx8YtTiu3xt0DbWlomi9K923rhVb6QC FPN9bzVLVOLSvY/Brg4sbIlKbgj1jEWXDj2fvIyK/BGqSKEY/og+uUCJH9KP9ryM 1IEHpBli+J6s5gIjNq62m1BKNNg5dgLo7ZwesDdE4iezVtK+7aFbK6b36umLeVdH czZ66V+VpUKrihBvuDfLXDreeWCwL3Ko6m3X8dzULoX+uY4OwNQi9dRy7x+tIWQM xesJJhBUQpXW8RTJWk1L9ypRBbiir/b9iRgx5v4FamArwfKz5yoyR68nZs33AwGt w8fzUWU0A8IZErVI6tv880/WN+Ty8gSU+QsadWFPux906aeVjbRhNn8MKG3WQ5X+ MKxW7IQ/uT4tlNRMWLA4AF+EZHvwCnaLiNiOzo2DF+pAyysUYEKtrrGIfl3nsYfQ 5hs/T04pccHUwJBw9X6u9OGeOFf2E/wKE5KBVTvnpkz9OPjCOhJHRAzSn4xoXyFN B4j1SvPlLw+4dZq8mB+b0kJLFuT3gwl3gXL8YmRBil0wsxLyA3Us+2xSmNtAxzWA crMuaahbTLdf3Mq28BymYfelK2TJtIpT9dSIuVrIl0ZYZQ+NNd/FE4GUm8OGqcQg NePUFDbcdgI7+PFqMe6K =CUZ0 -----END PGP SIGNATURE----- --wwrWGQD8DeJNIjlAVhEBPpMl4tmOAwMwD--