From owner-svn-src-all@FreeBSD.ORG Fri Sep 25 21:03:10 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9360E1065672 for ; Fri, 25 Sep 2009 21:03:10 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello087206049004.chello.pl [87.206.49.4]) by mx1.freebsd.org (Postfix) with ESMTP id D61938FC18 for ; Fri, 25 Sep 2009 21:03:09 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 867D245685; Fri, 25 Sep 2009 23:03:08 +0200 (CEST) Received: from localhost (chello087206049004.chello.pl [87.206.49.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 6EA0245683; Fri, 25 Sep 2009 23:03:03 +0200 (CEST) Date: Fri, 25 Sep 2009 23:03:06 +0200 From: Pawel Jakub Dawidek To: Adam McDougall Message-ID: <20090925210305.GB1597@garage.freebsd.pl> References: <200908170923.n7H9NR7t056904@svn.freebsd.org> <4ABD247D.40201@egr.msu.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2B/JsCI69OhZNC5r" Content-Disposition: inline In-Reply-To: <4ABD247D.40201@egr.msu.edu> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r196300 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris cddl/contrib/opensolaris/uts/common/fs/zfs contrib/dev/acpica contrib/pf dev/ata dev/cxgb dev/mfi dev/xen/netfron... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Sep 2009 21:03:10 -0000 --2B/JsCI69OhZNC5r Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 25, 2009 at 04:13:49PM -0400, Adam McDougall wrote: > Pawel Jakub Dawidek wrote: > >Author: pjd > >Date: Mon Aug 17 09:23:27 2009 > >New Revision: 196300 > >URL: http://svn.freebsd.org/changeset/base/196300 > > > >Log: > > MFC r196299: > > =20 > > - We need to recycle vnode instead of freeing znode. > > =20 > > Submitted by: avg > > =20 > > - Add missing vnode interlock unlock. > > - Remove redundant znode locking. > > =20 > > Approved by: re (kib) > > >=20 > Two quick questions: >=20 > - Do you think this fix would improve or fix the panic below? > (transcribed by hand since it did not dump and I only have a > screenshot) > - Are the many misc ZFS fixes that went into 9.0 and 8.0 going to > be MFC'ed to 7-stable sometime, including the one above? I have > lucked out pretty well so far since May. At this point I'm not going to MFC them into stable/7, although marck@ seems to be interested in doing it. > Sleeping thread (tid 100161), pid 919) owns a non-sleepable lock > sched_switch() at sched_switch+0x1fe > mi_switch() at mi_switch+0x18e > sleepq_wait() at sleepq_wait+0x3b > _sx_xlock_hard() at _sx_xlock_hard+0x1ee > _sx_xlock() at _sx_xlock+0x4e > rrw_enter() at rrw_enter+0xa4 > zfs_freebsd_getattr() at zfs_freebsd_getattr+0x9d > filt_vfsread() at filt_vfsread+_0x5e > knote() at knote+0xc2 It looks like kqueue is calling into ZFS with mutex held, which is bad... No, this bug is not fixed. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --2B/JsCI69OhZNC5r Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFKvTAJForvXbEpPzQRAn6sAKD0O14wAuQRFaIsIByTJ323Y9dLhACgtAlU 20C/i8lor84jqMQ3uSWQDUE= =wTwg -----END PGP SIGNATURE----- --2B/JsCI69OhZNC5r--