From owner-freebsd-multimedia@FreeBSD.ORG Thu Dec 6 21:44:03 2007 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D03C116A419 for ; Thu, 6 Dec 2007 21:44:03 +0000 (UTC) (envelope-from mezz7@cox.net) Received: from eastrmmtao104.cox.net (eastrmmtao104.cox.net [68.230.240.46]) by mx1.freebsd.org (Postfix) with ESMTP id 8F13013C4E5 for ; Thu, 6 Dec 2007 21:44:03 +0000 (UTC) (envelope-from mezz7@cox.net) Received: from eastrmimpo03.cox.net ([68.1.16.126]) by eastrmmtao104.cox.net (InterMail vM.7.08.02.01 201-2186-121-102-20070209) with ESMTP id <20071206214403.HBBT21580.eastrmmtao104.cox.net@eastrmimpo03.cox.net>; Thu, 6 Dec 2007 16:44:03 -0500 Received: from mezz.mezzweb.com ([24.255.149.218]) by eastrmimpo03.cox.net with bizsmtp id MZdx1Y00M4iy4EG0000000; Thu, 06 Dec 2007 16:37:58 -0500 Date: Thu, 06 Dec 2007 15:49:16 -0600 To: "Jona Joachim" From: "Jeremy Messenger" Content-Type: text/plain; format=flowed; delsp=yes; charset=us-ascii MIME-Version: 1.0 References: <200712060650.lB66o4kF022891@freefall.freebsd.org> Content-Transfer-Encoding: Quoted-Printable Message-ID: In-Reply-To: <200712060650.lB66o4kF022891@freefall.freebsd.org> User-Agent: Opera Mail/9.24 (Linux) Cc: freebsd-multimedia@freebsd.org Subject: Re: ports/118458: [UPDATE] multimedia/handbrake X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Dec 2007 21:44:03 -0000 On Thu, 06 Dec 2007 00:50:04 -0600, Jona Joachim wrote= : > The following reply was made to PR ports/118458; it has been noted by = = > GNATS. > > From: Jona Joachim > To: bug-followup@FreeBSD.org > Cc: > Subject: Re: ports/118458: [UPDATE] multimedia/handbrake > Date: Thu, 6 Dec 2007 07:13:02 +0100 > > Sorry for the excessive indentation in MASTER_SITES and DISTFILES, it= > did look fine in vim... That's ok, I already have cleaned that in local. Thanks for update = HandBrake! I like what you have done with it. I can't get your handbrake build. I keep get this build failure with and= = without modify of mine. I put the '-dx' back in for jam that way I can s= ee = the verbose of build. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D cc -c -o libhb/dvd.o -O2 -fno-strict-aliasing -pipe -g -O3 -funroll-loop= s = -I./contrib/include -DSYS_FREEBSD -DUSE_PTHREAD -DHB_VERSION=3D\"0.9.1\"= = -DHB_BUILD=3D2007100800 -D__LIBHB__ -Ilibhb libhb/dvd.c libhb/dvd.c:10:30: error: dvdread/ifo_read.h: No such file or directory libhb/dvd.c:11:30: error: dvdread/nav_read.h: No such file or directory =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D It can't find libdvdread, so.. I wonder why libdvdread's headers aren't = in = contrib/include/, so I went to check more in the log. It shows that = libdvdread configure failed. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D checking dvdcss/dvdcss.h usability... yes checking dvdcss/dvdcss.h presence... yes checking for dvdcss/dvdcss.h... yes checking for dvdcss_interface_2 in -ldvdcss... no configure: error: You need libdvdcss.so.2 or later =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D In the contrib/libdvdread/config.log looks like: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D configure:19289: checking for dvdcss_interface_2 in -ldvdcss configure:19307: cc -o conftest -O2 -fno-strict-aliasing -pipe -g = -I/usr/home/mezz/commit/handbrake/work/HandBrake/contrib/include = -L/usr/home/mezz/commit/handbrake/work/HandBrake/contrib/lib -ldvdcss = = conftest.c >&5 /var/tmp//ccJnz0pL.o(.text+0x13): In function `main': /usr/home/mezz/commit/handbrake/work/HandBrake/contrib/libdvdread/confte= st.c:29: = undefined reference to `dvdcss_interface_2' configure:19313: $? =3D 1 configure: failed program was: | /* confdefs.h. */ | | #define PACKAGE_NAME "" | #define PACKAGE_TARNAME "" | #define PACKAGE_VERSION "" | #define PACKAGE_STRING "" | #define PACKAGE_BUGREPORT "" | #define PACKAGE "libdvdread" | #define VERSION "0.9.7" | #define STDC_HEADERS 1 | #define HAVE_SYS_TYPES_H 1 | #define HAVE_SYS_STAT_H 1 | #define HAVE_STDLIB_H 1 | #define HAVE_STRING_H 1 | #define HAVE_MEMORY_H 1 | #define HAVE_STRINGS_H 1 | #define HAVE_INTTYPES_H 1 | #define HAVE_STDINT_H 1 | #define HAVE_UNISTD_H 1 | #define HAVE_DLFCN_H 1 | #ifdef __cplusplus | extern "C" void exit (int); | #endif | #define HAVE_DVDCSS_DVDCSS_H 1 | /* end confdefs.h. */ | #include | int | main () | { | if(!dvdcss_interface_2) { return 1; } | ; | return 0; | } configure:19334: result: no configure:19336: error: You need libdvdcss.so.2 or later =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D The libdvdcss.so.2.8 exists: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D # find work -name libdvdcss.so\* work/HandBrake/contrib/lib/libdvdcss.so.2.8 work/HandBrake/contrib/libdvdcss/src/.libs/libdvdcss.so.2.8 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D I doubt that it got conflict with libdvd* installed in my system, becaus= e = of it has correct -I/-L paths. But I will add my info in here just in = case. I haven't dig in it deeper, so I don't know. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D # pkg_info -IX libdvd libdvdcss-1.2.9_2 Portable abstraction library for DVD decryption libdvdnav-0.1.10_3 The library for the xine-dvdnav plugin libdvdread-0.9.7_2 This is needed by ogle, which is a DVD player that = supports =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D -- Here is a patch and list of what I have changed: http://people.freebsd.org/~mezz/diff/handbrake.diff - Move the 'apply' part from post-patch to post-extract. - Add post-patch to get this port respect the CC/CXX/CFLAGS/etc in ea= ch of ./configure in contrib/Jamfile. - Modified patch-contrib-Jamfile on ffmpeg part to get respect CC/PTHREAD_LIBS. - Re-add '-dx' for verbose build in jam, easier to debug when user re= port build failure. I am not done with that, but it's far what I have right now. I am planni= ng = to remove more stuff such as remove all of these -O3, -O4, -O20, = -funroll-loops and other flags as should be respect to our CFLAGS. Feel = = free to take this job if you want to. Also, do you want to take the = maintainership? We are willing to give up the maintainership as we have = no = interest in HandBrake and we will leaving it in dust again in future. Cheers, Mezz > Jona -- = mezz7@cox.net - mezz@FreeBSD.org FreeBSD GNOME Team - FreeBSD Multimedia Hat (ports, not src) http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org http://wiki.freebsd.org/multimedia - multimedia@FreeBSD.org