From nobody Sun Mar 26 17:08:38 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pl2Tv05lXz424hR for ; Sun, 26 Mar 2023 17:08:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pl2Tt5S8Tz3kTD for ; Sun, 26 Mar 2023 17:08:50 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52e.google.com with SMTP id ek18so26658540edb.6 for ; Sun, 26 Mar 2023 10:08:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; t=1679850529; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4kbGvLJ8gO+97y9HkGxG6sz3TbKkVcSV5WrMRF9kqI4=; b=CWaQ/EgZyZMiN7T02XI30E4HajQtJIMfHbRDs5L8MGyHdtE3PAkbcNqTLTEGA+WWJF 6UG/X8A/oksPIhEKtFSDzAk/vZLGw5CzWVKq05zvhGqn+QjTCydvJbpsHuMhGNjAwfhZ ms/wc8S6Iq4nVocLHdwA7dL0FAZHtBENh/XzgOSJU+nvCkaaEwy0MjXj8CmMvySzHUXS fs/jIXUSTsGbjm6/gdmGHC+SPVHDPGuS+HlJnm057v5TOgo5Seqb02E2+Tq+A16AMeRC 10yVoJrQCbkAW/xv2mVy4jNMupdGjEjZOvcpiUePJGtAzFC0ZY166Dpame1/19mZc121 3zxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679850529; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4kbGvLJ8gO+97y9HkGxG6sz3TbKkVcSV5WrMRF9kqI4=; b=ynhjPiphdokC91vps/0bjVO0QITd79IIUO+eDr9AYR37jbodFjrp5gbwt0UKpJP6// mArFxxy4IOhqN8ELE2t+/6j3lXVdo/5CA/Y7GSrASeQiV/BLYPCaWnADIF6rBjiotIyw HMhkPJijcQeNctdk+H1uUIkzo5BvN3cx0i0ZD+8csXAwmVG7F5E6WuBgebWUtac5v2O0 +Xb25ZwGcewL+epUg3o31olp5/lhz7GrT1uRyZ+mC5uet3mUiaQrDYoejnNnsbYXD6gk JohTXEvB/f46uHRbwBVRCFQZzq2pfE/iExpXBMLh/wQJtpPS30zWbM7Ft4uQw7pzkMAu o8xw== X-Gm-Message-State: AAQBX9dIuaVL9i1Cl2TcT2VWv4LsF/eF7IuSdz+bji2+3zjHB8o0eq8z mmMRFepmr8uS+8HH51VA2BR4aBYv0ptiKmiXQMYCHQ== X-Google-Smtp-Source: AKy350YD+xDdKWIQa0FK8liHUF0PigheZiXGSN+PmldCs5mnvA4Rc2TvHT+XYB+woRDVK6ra337Qr/Yd0Ypue88gyDw= X-Received: by 2002:a17:907:d687:b0:93d:a14f:c9b4 with SMTP id wf7-20020a170907d68700b0093da14fc9b4mr4308425ejc.2.1679850529367; Sun, 26 Mar 2023 10:08:49 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202303261107.32QB7T7N058867@gitrepo.freebsd.org> <486C839F-181F-4CE8-8510-4A7D4D100FDC@freebsd.org> In-Reply-To: <486C839F-181F-4CE8-8510-4A7D4D100FDC@freebsd.org> From: Warner Losh Date: Sun, 26 Mar 2023 19:08:38 +0200 Message-ID: Subject: Re: git: a85dcd4ac4b0 - main - netlink: restrict default userland switch to netlink to i386/amd64. To: Jessica Clarke Cc: "Alexander V. Chernikov" , Ed Maste , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000014576405f7d0aed5" X-Rspamd-Queue-Id: 4Pl2Tt5S8Tz3kTD X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --00000000000014576405f7d0aed5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Mar 26, 2023, 6:45 PM Jessica Clarke wrote: > On 26 Mar 2023, at 17:17, Ed Maste wrote: > > > > > > On Sun, 26 Mar 2023 at 07:07, Alexander V. Chernikov > > wrote: > >> > >> The branch main has been updated by melifaro: > >> > >> URL: > https://cgit.FreeBSD.org/src/commit/?id=3Da85dcd4ac4b0612b63b5a71eeaaa707= a09ae0003 > >> > >> commit a85dcd4ac4b0612b63b5a71eeaaa707a09ae0003 > >> Author: Alexander V. Chernikov > >> AuthorDate: 2023-03-26 11:05:21 +0000 > >> Commit: Alexander V. Chernikov > >> CommitDate: 2023-03-26 11:06:53 +0000 > >> > >> netlink: restrict default userland switch to netlink to i386/amd64. > > > > We should keep default options the same for all Tier-1 architectures, > > so amd64 and arm64 should be in sync. > > But also, what=E2=80=99s the technical justification for this change? The= re > should not be gratuitous differences between architectures like this, > only when there is a reason something shouldn=E2=80=99t be enabled. Why s= hould > x86 (and possibly arm64) get netlink, but not arm/powerpc/riscv? We > have very few machine-dependent defaults in src.opts.mk. If there is no > such justification then please revert this in its entirety, and if > there is such a justification it belongs in a comment above the if. > So if it's a matter of testing, enable it everywhere. We'll get testing. If it's something known to be bad on say riscv64 we should have a bug and reference it in src.opts.mk to document why. If it's just a conservative approach to a roll out, then I'd suggest being less conservative. Warner > --00000000000014576405f7d0aed5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sun, Mar 26, 2023, 6:45 PM Jessica Clarke <jrtc27@freebsd.org> wrote:
On 26 Mar 2023, at 17:17, Ed Maste <emas= te@freebsd.org> wrote:
>
>
> On Sun, 26 Mar 2023 at 07:07, Alexander V. Chernikov
> <melifaro@freebsd.org> wrote:
>>
>> The branch main has been updated by melifaro:
>>
>> URL: https://cgit.FreeBSD.org/src/commit/?id=3Da85dcd4ac4b0612b63b5a71eea= aa707a09ae0003
>>
>> commit a85dcd4ac4b0612b63b5a71eeaaa707a09ae0003
>> Author:=C2=A0 =C2=A0 =C2=A0Alexander V. Chernikov <melifaro@Fre= eBSD.org>
>> AuthorDate: 2023-03-26 11:05:21 +0000
>> Commit:=C2=A0 =C2=A0 =C2=A0Alexander V. Chernikov <melifaro@Fre= eBSD.org>
>> CommitDate: 2023-03-26 11:06:53 +0000
>>
>>=C2=A0 =C2=A0 netlink: restrict default userland switch to netlink = to i386/amd64.
>
> We should keep default options the same for all Tier-1 architectures,<= br> > so amd64 and arm64 should be in sync.

But also, what=E2=80=99s the technical justification for this change? There=
should not be gratuitous differences between architectures like this,
only when there is a reason something shouldn=E2=80=99t be enabled. Why sho= uld
x86 (and possibly arm64) get netlink, but not arm/powerpc/riscv? We
have very few machine-dependent defaults in src.opts.mk. If there i= s no
such justification then please revert this in its entirety, and if
there is such a justification it belongs in a comment above the if.

So if it= 's a matter of testing, enable it everywhere. We'll get testing. If= it's something known to be bad on say riscv64 we should have a bug and= reference it in src.opts.mk to document= why. If it's just a conservative approach to a roll out, then I'd = suggest being less conservative.=C2=A0

Warner
--00000000000014576405f7d0aed5--