From owner-cvs-src@FreeBSD.ORG Mon Jun 9 16:17:56 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 920C7106564A for ; Mon, 9 Jun 2008 16:17:56 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.152]) by mx1.freebsd.org (Postfix) with ESMTP id 187058FC0A for ; Mon, 9 Jun 2008 16:17:55 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: by fg-out-1718.google.com with SMTP id l26so1853924fgb.35 for ; Mon, 09 Jun 2008 09:17:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=BIzWA6wvpLRfbVgXlwPI3FmKGarsTNyT8b2LZspbkss=; b=Tyrjz0q5FRu0z4hYTp7wa/Bb6huK0FjQ4wJBSpHuv4kMS6uv0ULQSSluxW8nPkuFaX /PEtFQ0tVPGexUalV7qhwfnU9jGggEOyHb8qmoNuIMHuAQR95yUceWuuRPVqrjzc2A1s 9Fjsp6SmQ3LZ9MrwJcYm5YYiO+hShqkH6PKv0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=bGdhfBjUtx+sJb6XQ36548321Bnr8MeRxhzZwOgt0cVgpaxmTj7rZYLvmKDOCKvaWv SHkbX8FJz+1KwqMjpdAGsUN2JImQVtjY06vQuwTXAmyu3FFZhaz3tnZbcvphplBDVcTN CFJmDoq/pKcR5mz2jZVo5WA/iLmsk4bfzObNg= Received: by 10.86.63.19 with SMTP id l19mr4474506fga.77.1213028274087; Mon, 09 Jun 2008 09:17:54 -0700 (PDT) Received: by 10.86.26.8 with HTTP; Mon, 9 Jun 2008 09:17:54 -0700 (PDT) Message-ID: <7d6fde3d0806090917h2ed0799dv6b7044a959e039af@mail.gmail.com> Date: Mon, 9 Jun 2008 09:17:54 -0700 From: "Garrett Cooper" To: "Doug Barton" In-Reply-To: <484D5719.1070907@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200805261721.m4QHLCF4070787@repoman.freebsd.org> <20080608075256.GA35560@obiwan.tataz.chchile.org> <484CB927.3050101@freebsd.org> <484D5719.1070907@FreeBSD.org> Cc: Jeremie Le Hen , cvs-src@freebsd.org, Tim Kientzle , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit [HEAD] src/gnu/usr.bin/cpio Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jun 2008 16:17:56 -0000 On Mon, Jun 9, 2008 at 9:15 AM, Doug Barton wrote: > Tim Kientzle wrote: >> >> This case is a little unusual: by default, I want to >> install both 'cpio' programs and symlink the common name >> to one of them. > > I'm not sure how that relates to Jeremie's (valid) point that these flags > need to be part of the system in bsd.own.mk. I admit that getting stuff in > there was a little intimidating to me at first, but Ruslan has created a > nice automated system, and he'll be glad to help you if you need it. > >> How about this: >> WITH_GCPIO (default) - installs gcpio, symlinks 'cpio' unless >> WITH_BSDCPIO defined >> WITHOUT_GCPIO - does not install gcpio at all >> WITH_BSDCPIO (default) - installs bsdcpio, symlinks 'cpio' >> WITHOUT_BSDCPIO - does not install bsdcpio at all > > If by "not install" you mean "build or install" then I'm with you, but I > think it might be a little complicated. I'm not sure why you want to build > and install both by default (except maybe to ease people's concerns in the > interim period) but if it were me, in HEAD I would do this: > > WITH_BSDCPIO (default) build, install, and symlink to cpio > WITHOUT_GCPIO (default) do not build or install > > Then if WITHOUT_BSDCPIO is defined you don't build or install it, and if > WITH_GCPIO is defined you build, install, and symlink it, regardless of the > state of the BSDCPIO knob. > > When this gets MFC'ed I would just flip the defaults. > > > FWIW, > > Doug I agree completely with Doug. -Garrett