From owner-svn-src-head@FreeBSD.ORG Sun Feb 28 18:00:20 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E5A921065672; Sun, 28 Feb 2010 18:00:20 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-iw0-f191.google.com (mail-iw0-f191.google.com [209.85.223.191]) by mx1.freebsd.org (Postfix) with ESMTP id 7F3748FC19; Sun, 28 Feb 2010 18:00:20 +0000 (UTC) Received: by iwn29 with SMTP id 29so1032094iwn.27 for ; Sun, 28 Feb 2010 10:00:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=R8aTXVe5DYvvn+KEc9x59dm42tCKG4husQgxbIatDW8=; b=aDxYxh+W6zK8FaqHb0DkSdyFNYjbleSeFVQToOluhgzseurHDaki8mdApRZ7DqiPB4 rliCSIlj8CjtN4RwG+uuEUExrzMKyTDqjFcgC8+wanGzyL+gGNijkKdT3JdpOXXkjfiG uIpXrsSAoLRoeUmXwJ1S83Msb9Z+v9EHC+y6k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=sup/8lApLumxShqVIqkV7TNMeRA+y779zYhKtHwAlE1xcpPhUQl/iq5XmEw+DFR+lQ Rfr+hcrrQJH0hV5x7i7G9FVhQbktkXsrPBj3vMwAiJ8LHNs3fuitimhNnFP0tekAq6gP g9xLrvRvqPVLCwQ+e+F+I4CRSPKG0iPXv7juM= MIME-Version: 1.0 Sender: asmrookie@gmail.com Received: by 10.231.150.2 with SMTP id w2mr115236ibv.90.1267380010691; Sun, 28 Feb 2010 10:00:10 -0800 (PST) In-Reply-To: <201002281713.o1SHD74Q040738@svn.freebsd.org> References: <201002281713.o1SHD74Q040738@svn.freebsd.org> Date: Sun, 28 Feb 2010 19:00:10 +0100 X-Google-Sender-Auth: 0afa604f6f95341d Message-ID: <3bbf2fe11002281000i5a6ebb35seadd6cb8f506d65e@mail.gmail.com> From: Attilio Rao To: Konstantin Belousov Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r204470 - head/sys/fs/msdosfs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Feb 2010 18:00:21 -0000 2010/2/28 Konstantin Belousov : > Author: kib > Date: Sun Feb 28 17:13:07 2010 > New Revision: 204470 > URL: http://svn.freebsd.org/changeset/base/204470 > > Log: > =C2=A0Add per-mountpoint lockmgr lock for msdosfs. It is intended to be u= sed > =C2=A0as fat bitmap lock and to replace global mutex protecting fileno rb= tree. Looking at this patch, it seems you can safely use a sx lock here and I would prefer that as we don't want to encourage more lockmgr to get in. If you are concerned about writer starvation in any way here, probabilly the right solution is to implement it in sx and remove lockmgr also from the export code. Attilio --=20 Peace can only be achieved by understanding - A. Einstein