From owner-cvs-all@FreeBSD.ORG  Wed Apr 30 00:43:40 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C634137B401; Wed, 30 Apr 2003 00:43:39 -0700 (PDT)
Received: from mailhub.fokus.fraunhofer.de (mailhub.fokus.fraunhofer.de
	[193.174.154.14])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4C40043F75; Wed, 30 Apr 2003 00:43:38 -0700 (PDT)
	(envelope-from brandt@fokus.fraunhofer.de)
Received: from beagle (beagle [193.175.132.100])h3U7hWE04575;
	Wed, 30 Apr 2003 09:43:32 +0200 (MEST)
Date: Wed, 30 Apr 2003 09:43:32 +0200 (CEST)
From: Harti Brandt <brandt@fokus.fraunhofer.de>
To: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20030429.122808.116092806.imp@bsdimp.com>
Message-ID: <20030430093931.V31027@beagle.fokus.fraunhofer.de>
References: <20030429054515.D74EF37B490@hub.freebsd.org>
	<20030429.122808.116092806.imp@bsdimp.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: nate@root.org
Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Apr 2003 07:43:40 -0000

On Tue, 29 Apr 2003, M. Warner Losh wrote:

MWL>In message: <Pine.BSF.4.21.0304291101001.75697-100000@root.org>

MWL>: >           4) Return immediately if gone is true in fxp_ioctl
MWL>: >           5) Return immediately if gone is true in fxp_intr
MWL>:
MWL>: Not sure this approach is necessary.
MWL>
MWL>I am.  Otherwise ioctl panics with recursive locks when the card is
MWL>detached.  A simple kld_unload if_fxp would provoke these races,
MWL>including the recursive lock panic.

You can replace the pointers to ioctl and start with pointers to dummy
functions. In fact, an if_dead(ifp) function which does just this would
be nice to have.

harti
-- 
harti brandt,
http://www.fokus.fraunhofer.de/research/cc/cats/employees/hartmut.brandt/private
brandt@fokus.fraunhofer.de, harti@freebsd.org