From owner-freebsd-current  Wed Feb 27 15:19:31 2002
Delivered-To: freebsd-current@freebsd.org
Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75])
	by hub.freebsd.org (Postfix) with ESMTP id 723CC37B41A
	for <current@FreeBSD.ORG>; Wed, 27 Feb 2002 15:19:27 -0800 (PST)
Received: (from brdavis@localhost)
	by odin.ac.hmc.edu (8.11.0/8.11.0) id g1RNJ4425210;
	Wed, 27 Feb 2002 15:19:04 -0800
Date: Wed, 27 Feb 2002 15:19:04 -0800
From: Brooks Davis <brooks@one-eyed-alien.net>
To: Peter Wemm <peter@wemm.org>
Cc: Alfred Perlstein <bright@mu.org>,
	Matthew Dillon <dillon@apollo.backplane.com>,
	Julian Elischer <julian@elischer.org>,
	FreeBSD current users <current@FreeBSD.ORG>
Subject: Re: controversial fix or some errors breaking LINT
Message-ID: <20020227151904.A22221@Odin.AC.HMC.Edu>
References: <20020227225459.GY80761@elvis.mu.org> <20020227231509.EB2B93809@overcee.wemm.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-md5;
	protocol="application/pgp-signature"; boundary="17pEHd4RhPHOinZp"
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20020227231509.EB2B93809@overcee.wemm.org>; from peter@wemm.org on Wed, Feb 27, 2002 at 03:15:09PM -0800
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG


--17pEHd4RhPHOinZp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 27, 2002 at 03:15:09PM -0800, Peter Wemm wrote:
> If there are files that are too hard to fix, or vendor files, or the fix
> isn't clear, we should use the nowerror conf/files* flags.
>=20
> It is important that we stop new warnings turning up when the compile
> output is so damn large that it hides things.

I definatly agree.  The warnings in gif(4) were mostly lame and should
have been fixed, but no one bothered.

> I will do a pass over things now and see what I can do.

Please make sure to test the !SMP case.  The following slipped through
the initial sweep:

Index: kern_sig.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /usr/cvs/src/sys/kern/kern_sig.c,v
retrieving revision 1.149
diff -u -r1.149 kern_sig.c
--- kern_sig.c	23 Feb 2002 11:12:54 -0000	1.149
+++ kern_sig.c	26 Feb 2002 19:37:00 -0000
@@ -1233,7 +1233,9 @@
 	register int prop;
 	register sig_t action;
 	struct thread *td;
+#ifdef SMP
 	struct ksegrp *kg;
+#endif
=20
 	KASSERT(_SIG_VALID(sig),
 	    ("psignal(): invalid signal %d\n", sig));

-- Brooks

--=20
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4

--17pEHd4RhPHOinZp
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8fWlnXY6L6fI4GtQRAhCVAKDMzXnNjSnFUq9PFV8q5Gfc5mxQsQCffNyu
0G182CDT9msYhsN8wMmetBI=
=GAPd
-----END PGP SIGNATURE-----

--17pEHd4RhPHOinZp--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message